cc/quads/render_pass.cc - Issue 2029813002: cc::SharedQuadState: drop CopyFrom and add copy constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/render_pass.cc

Issue 2029813002: cc::SharedQuadState: drop CopyFrom and add copy constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use = default in cc Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/render_pass.cc

diff --git a/cc/quads/render_pass.cc b/cc/quads/render_pass.cc

index 0a868e3e057c084b2b7b8b31924b0ac47d09552b..125291f0ca5063274f15e12822fecf67572ad7c3 100644

--- a/cc/quads/render_pass.cc

+++ b/cc/quads/render_pass.cc

@@ -112,7 +112,7 @@ void RenderPass::CopyAll(const std::vector<std::unique_ptr<RenderPass>>& in,

for (const auto& shared_quad_state : source->shared_quad_state_list) {

SharedQuadState* copy_shared_quad_state =

copy_pass->CreateAndAppendSharedQuadState();

- copy_shared_quad_state->CopyFrom(shared_quad_state);

+ *copy_shared_quad_state = *shared_quad_state;

}

SharedQuadStateList::Iterator sqs_iter =

source->shared_quad_state_list.begin();

« no previous file with comments | « cc/quads/draw_quad_unittest.cc ('k') | cc/quads/shared_quad_state.h » ('j') | no next file with comments »