OOPIF IME: Renderer Side Changes

third_party/WebKit/Source/web/WebViewImpl.h

Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index f1fb678152bd9770d263301470c8bb3be8732d4c..f2a0c2c015e7d49f82542bfc7316eb2d57e8ed25 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -158,6 +158,7 @@ public:
     void didLosePointerLock() override;
     void didChangeWindowResizerRect() override;
     void reportFixedRasterScaleUseCounters(bool hasBlurryContent, bool hasPotentialPerformanceRegression) override;
+    bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;

[kenrb, 2016/06/07 20:18:13]

The IME methods in WebViewImpl could possibly be moved to WebFrameWidgetImpl,
but I don't have a strong opinion. Things that deal strictly with a focused
frame should be fine here. Daniel might have an opinion on that one way or the
other.

[dcheng, 2016/06/08 04:39:43]

It seems inconsistent to move the code off RenderView to RenderWidget but not
off WebView to WebFrameWidget. So I think we should do that in this CL as well,
rather than just having WebFrameWidget delegate to WebViewImpl.

[kenrb, 2016/06/08 15:26:04]

A bit more concrete argument for this that I thought of is that if there is race
contention between IME messages and focus changes, we could end up with IME
messages going to a RenderWidget that does not have the currently focused frame
underneath it. If focus is changing to another process then it should be fine,
nothing will happen. But if it is moving to a frame another RenderWidget in the
same process then that might change the behavior. It seems a lot more consistent
to have this code in WebFrameWidgetImpl and verify that focused frame (if not
nullptr) has the correct local root.

[EhsanK, 2016/06/09 03:24:26]

Acknowledged.

[EhsanK, 2016/06/09 03:24:26]

Acknowledged.

 
     // WebView methods:
     virtual bool isWebView() const { return true; }