OOPIF IME: Renderer Side Changes

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 4998d018a4b0aa5acf4cb15650c0c993af9e3956..30eb7e23c2822d5ac0c713df0cc660de0450f0ef 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -466,32 +466,28 @@ bool WebFrameWidgetImpl::setComposition(
     int selectionStart,
     int selectionEnd)
 {
-    // FIXME: To be implemented.
-    return false;
+    return view()->setComposition(text, underlines, selectionStart, selectionEnd);

[EhsanK, 2016/06/09 03:24:26]

Following the comments on getCompositionCharacterBounds, I believe these have to
also be implemented for WebFrameWidgetImpl separately. At this point I am not
sure yet how much work this needs. Does not seem like much.

 }
 
 bool WebFrameWidgetImpl::confirmComposition()
 {
     // FIXME: To be implemented.
-    return false;
+    return view()->confirmComposition();
 }
 
 bool WebFrameWidgetImpl::confirmComposition(ConfirmCompositionBehavior selectionBehavior)
 {
-    // FIXME: To be implemented.
-    return false;
+    return view()->confirmComposition(selectionBehavior);
 }
 
 bool WebFrameWidgetImpl::confirmComposition(const WebString& text)
 {
-    // FIXME: To be implemented.
-    return false;
+    return view()->confirmComposition(text);
 }
 
 bool WebFrameWidgetImpl::compositionRange(size_t* location, size_t* length)
 {
-    // FIXME: To be implemented.
-    return false;
+    return view()->compositionRange(location, length);
 }
 
 WebTextInputInfo WebFrameWidgetImpl::textInputInfo()
@@ -645,6 +641,11 @@ void WebFrameWidgetImpl::didChangeWindowResizerRect()
         m_localRoot->frameView()->windowResizerRectChanged();
 }
 
+bool WebFrameWidgetImpl::getCompositionCharacterBounds(WebVector<WebRect>& bounds)
+{
+    return view()->getCompositionCharacterBounds(bounds);
+}
+
 void WebFrameWidgetImpl::handleMouseLeave(LocalFrame& mainFrame, const WebMouseEvent& event)
 {
     // FIXME: WebWidget doesn't have the method below.