OOPIF IME: Renderer Side Changes

third_party/WebKit/Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 140 matching lines @@
     bool isSelectionAnchorFirst() const override;
     bool caretOrSelectionRange(size_t* location, size_t* length) override;
     void setTextDirection(WebTextDirection) override;
     bool isAcceleratedCompositingActive() const override;
     void willCloseLayerTreeView() override;
     void didAcquirePointerLock() override;
     void didNotAcquirePointerLock() override;
     void didLosePointerLock() override;
     void didChangeWindowResizerRect() override;
     void reportFixedRasterScaleUseCounters(bool hasBlurryContent, bool hasPotentialPerformanceRegression) override;
+    bool getCompositionCharacterBounds(WebVector<WebRect>& bounds) override;

[kenrb, 2016/06/07 20:18:13]

The IME methods in WebViewImpl could possibly be moved to WebFrameWidgetImpl,
but I don't have a strong opinion. Things that deal strictly with a focused
frame should be fine here. Daniel might have an opinion on that one way or the
other.

[dcheng, 2016/06/08 04:39:43]

It seems inconsistent to move the code off RenderView to RenderWidget but not
off WebView to WebFrameWidget. So I think we should do that in this CL as well,
rather than just having WebFrameWidget delegate to WebViewImpl.

[kenrb, 2016/06/08 15:26:04]

A bit more concrete argument for this that I thought of is that if there is race
contention between IME messages and focus changes, we could end up with IME
messages going to a RenderWidget that does not have the currently focused frame
underneath it. If focus is changing to another process then it should be fine,
nothing will happen. But if it is moving to a frame another RenderWidget in the
same process then that might change the behavior. It seems a lot more consistent
to have this code in WebFrameWidgetImpl and verify that focused frame (if not
nullptr) has the correct local root.

[EhsanK, 2016/06/09 03:24:26]

Acknowledged.

[EhsanK, 2016/06/09 03:24:26]

Acknowledged.

 
     // WebView methods:
     virtual bool isWebView() const { return true; }
     void setMainFrame(WebFrame*) override;
     void setCredentialManagerClient(WebCredentialManagerClient*) override;
     void setPrerendererClient(WebPrerendererClient*) override;
     void setSpellCheckClient(WebSpellCheckClient*) override;
     WebSettings* settings() override;
     WebString pageEncoding() const override;
     void setPageEncoding(const WebString&) override;
@@ skipping 597 matching lines @@
     double m_lastFrameTimeMonotonic;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif