Fix generation of inner_url in GURL::ReplacementComponents.

Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
Committed: https://crrev.com/73cea7e4afe9d7ffc45cecc80da954a481bbb48d
Cr-Commit-Position: refs/heads/master@{#399501}

[mmenke, 2016-06-01 19:49:13]

Description was changed from

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
==========

to

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
==========

[mmenke, 2016-06-01 20:39:41]

mmenke@chromium.org changed reviewers:
+ abarth@google.com

[mmenke, 2016-06-01 20:39:42]

https://codereview.chromium.org/2029213002/diff/1/url/gurl_unittest.cc
File url/gurl_unittest.cc (right):

https://codereview.chromium.org/2029213002/diff/1/url/gurl_unittest.cc#newcod...
url/gurl_unittest.cc:420:
"filesystem:http://www.google.com/foo/bar.html?foo#bar"},
Other than the addition of the last test case, the rest of this is just the
result of "git cl format"

https://codereview.chromium.org/2029213002/diff/1/url/gurl_unittest.cc#newcod...
url/gurl_unittest.cc:441: EXPECT_EQ(replace_cases[i].expected,
output.inner_url()->spec());
I'm not sure if the inner_url's spec is suppose to match the "outer URL's" one
(There's no test for inner_url->spec() in this file!?), but this is the behavior
for the non-ReplaceComponents case, too.

[mmenke, 2016-06-01 20:40:05]

mmenke@chromium.org changed reviewers:
+ abarth@chromium.org
- abarth@google.com

[mmenke, 2016-06-06 15:21:33]

abarth:  Ping!

[mmenke, 2016-06-09 15:00:02]

mmenke@chromium.org changed reviewers:
+ brettw@chromium.org
- abarth@chromium.org

[mmenke, 2016-06-09 15:00:03]

[+brettw]:  Please take a look.

[brettw, 2016-06-10 20:35:31]

Inner_url.spec being different is super confusing! I can see how that happens
because of the way these things are returned from being parsed (the parsing
process just references into the same buffer).

Can you (1) file a bug, (2) add a note referencing this bug on the inner_url()
getter in gurl.h, and (3) a note on the test where you check it about the bug
(so people know the test should be updated when the bug is fixed rather than
fretting about breaking stuff).

LGTM with that.

[mmenke, 2016-06-13 15:39:22]

On 2016/06/10 20:35:31, brettw wrote:
> Inner_url.spec being different is super confusing! I can see how that happens
> because of the way these things are returned from being parsed (the parsing
> process just references into the same buffer).
> 
> Can you (1) file a bug, (2) add a note referencing this bug on the inner_url()
> getter in gurl.h, and (3) a note on the test where you check it about the bug
> (so people know the test should be updated when the bug is fixed rather than
> fretting about breaking stuff).
> 
> LGTM with that.

Thanks!  Filed the bug (Without a label - there doesn't really seem to be one
for GURL issues.  There is internals>network, but while we occasionally deal
with GURL issues, not really in our purview), updated the CL.

[mmenke, 2016-06-13 15:39:43]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-06-13 15:39:44]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2029213002/#ps20001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-06-13 15:40:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029213002/20001

[commit-bot: I haz the power, 2016-06-13 16:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 16:46:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mmenke, 2016-06-13 16:47:32]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-06-13 16:48:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029213002/20001

[commit-bot: I haz the power, 2016-06-13 19:05:08]

Description was changed from

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
==========

to

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
==========

[commit-bot: I haz the power, 2016-06-13 19:05:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 19:05:19]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 19:09:07]

Description was changed from

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820
==========

to

==========
Fix generation of inner_url in GURL::Replacements.

It was being created using a combination of the old and new URLs,
instead of just using the new URL.

BUG=615820

Committed: https://crrev.com/73cea7e4afe9d7ffc45cecc80da954a481bbb48d
Cr-Commit-Position: refs/heads/master@{#399501}
==========

[commit-bot: I haz the power, 2016-06-13 19:09:08]

Patchset 2 (id:??) landed as
https://crrev.com/73cea7e4afe9d7ffc45cecc80da954a481bbb48d
Cr-Commit-Position: refs/heads/master@{#399501}