url/gurl.h - Issue 2029213002: Fix generation of inner_url in GURL::ReplacementComponents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.h

Issue 2029213002: Fix generation of inner_url in GURL::ReplacementComponents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url/gurl.h

diff --git a/url/gurl.h b/url/gurl.h

index 103f1d8519ca1a323b3dd576235bca4490382a4f..8a1750fa5bb42b438ab395abd32ca45bde04027d 100644

--- a/url/gurl.h

+++ b/url/gurl.h

@@ -394,6 +394,10 @@ class URL_EXPORT GURL {

// Returns the inner URL of a nested URL (currently only non-null for

// filesystem URLs).

+ //

+ // TODO(mmenke): inner_url().spec() currently returns the same value as

+ // caling spec() on the GURL itself. This should be fixed.

+ // See https://crbug.com/619596

const GURL* inner_url() const {

return inner_url_.get();

}

« no previous file with comments | « no previous file | url/gurl.cc » ('j') | no next file with comments »