Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: url/gurl.cc

Issue 2029213002: Fix generation of inner_url in GURL::ReplacementComponents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/gurl.h ('k') | url/gurl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/gurl.cc
diff --git a/url/gurl.cc b/url/gurl.cc
index 2b67beebc498d4a44bb224135110faa5ad324c65..2f8181329dd2e1b191dac2398f73da6c3e1861a5 100644
--- a/url/gurl.cc
+++ b/url/gurl.cc
@@ -280,7 +280,8 @@ GURL GURL::ReplaceComponents(
output.Complete();
if (result.is_valid_ && result.SchemeIsFileSystem()) {
- result.inner_url_.reset(new GURL(spec_.data(), result.parsed_.Length(),
+ result.inner_url_.reset(new GURL(result.spec_.data(),
+ result.parsed_.Length(),
*result.parsed_.inner_parsed(), true));
}
return result;
@@ -306,7 +307,8 @@ GURL GURL::ReplaceComponents(
output.Complete();
if (result.is_valid_ && result.SchemeIsFileSystem()) {
- result.inner_url_.reset(new GURL(spec_.data(), result.parsed_.Length(),
+ result.inner_url_.reset(new GURL(result.spec_.data(),
+ result.parsed_.Length(),
*result.parsed_.inner_parsed(), true));
}
return result;
« no previous file with comments | « url/gurl.h ('k') | url/gurl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698