chrome/browser/notifications/notification_builder_mac.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_builder_mac.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS build Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm ('k') | chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm » ('j') | ios/web/web_state/web_state_delegate_bridge_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_builder_mac.mm

diff --git a/chrome/browser/notifications/notification_builder_mac.mm b/chrome/browser/notifications/notification_builder_mac.mm

index 321f9c319fbd09376bf59007b40597b5a1b8f5f9..7a92e2503357a9d99c4d0cce4bef72d106e0c5f0 100644

--- a/chrome/browser/notifications/notification_builder_mac.mm

+++ b/chrome/browser/notifications/notification_builder_mac.mm

@@ -42,14 +42,14 @@ @implementation NotificationBuilder {

- (instancetype)init {

if ((self = [super init])) {

- notificationData_ = [[NSMutableDictionary alloc] init];

+ notificationData_.reset([[NSMutableDictionary alloc] init]);

}

return self;

}

- (instancetype)initWithDictionary:(NSDictionary*)data {

if ((self = [super init])) {

- notificationData_ = [data copy];

+ notificationData_.reset([data copy]);

}

return self;

}