ios/web/web_state/web_state_delegate_bridge_unittest.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_state_delegate_bridge_unittest.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS build Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/web_state/web_state_delegate_bridge_unittest.mm

diff --git a/ios/web/web_state/web_state_delegate_bridge_unittest.mm b/ios/web/web_state/web_state_delegate_bridge_unittest.mm

index 9e10434d94991304974fee7fe72769c0b90f27db..da6da8379cfbf8ca656fcfc8f0bbff577d0b1107 100644

--- a/ios/web/web_state/web_state_delegate_bridge_unittest.mm

+++ b/ios/web/web_state/web_state_delegate_bridge_unittest.mm

@@ -53,7 +53,7 @@ void TearDown() override {

context_menu_params.link_url = GURL("http://www.url.com");

context_menu_params.src_url = GURL("http://www.url.com/image.jpeg");

context_menu_params.referrer_policy = web::ReferrerPolicyOrigin;

- context_menu_params.view = [UIView new];

+ context_menu_params.view.reset([UIView new]);

Eugene But (OOO till 7-30) 2016/06/01 05:12:07 Optional NIT: Since you touching this, could you p

context_menu_params.location = CGPointMake(5.0, 5.0);

bridge_->HandleContextMenu(nullptr, context_menu_params);

web::ContextMenuParams* result_params = [delegate_ contextMenuParams];

« no previous file with comments | « ios/chrome/browser/passwords/password_controller_unittest.mm ('k') | no next file » | no next file with comments »