chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm - Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

Issue 2028823003: Mac: Make ScopedTypeRef require explicit constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix iOS build Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/mac/scoped_typeref.h ('k') | chrome/browser/notifications/notification_builder_mac.mm » ('j') | ios/web/web_state/web_state_delegate_bridge_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

diff --git a/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm b/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

index 6ba5bb71f5c6c3226a1ce431ecd0e6d86f5cce42..ce2f5087bd39e5128d41643cd09207bd1e03b7b1 100644

--- a/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

+++ b/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

@@ -140,7 +140,7 @@ void OnResolveComplete(

ServiceResolverImplMac* resolver_impl =

static_cast<ServiceResolverImplMac*>(resolver.get());

resolver_impl->GetContainerForTesting()->SetServiceForTesting(

- test_service.release());

+ base::scoped_nsobject<NSNetService>(test_service));

resolver->StartResolving();

resolver_impl->GetContainerForTesting()->OnResolveUpdate(