Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2027693003: Revert cursor changes to RenderWidgetHostViewAura. (Closed)

Created:
4 years, 6 months ago by Elliot Glaysher
Modified:
4 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert cursor changes to RenderWidgetHostViewAura. This is a selective revert of one file from https://codereview.chromium.org/1945423002, which was breaking cursor changes on zoom in/zoom out on the Linux version of chrome. BUG=602727, 614654 Committed: https://crrev.com/b9020bacdaff760ec0acc4fc5e9db9239438636d Cr-Commit-Position: refs/heads/master@{#396977}

Patch Set 1 #

Total comments: 1

Patch Set 2 : include guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Elliot Glaysher
Funnily enough, this doesn't break anything in mash since all the cursor stuff regressed in ...
4 years, 6 months ago (2016-05-31 19:09:18 UTC) #2
sadrul
lgtm Can this be tested? https://codereview.chromium.org/2027693003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/2027693003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode2463 content/browser/renderer_host/render_widget_host_view_aura.cc:2463: #endif Since you are ...
4 years, 6 months ago (2016-05-31 20:25:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027693003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027693003/20001
4 years, 6 months ago (2016-05-31 21:53:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 23:43:11 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b9020bacdaff760ec0acc4fc5e9db9239438636d Cr-Commit-Position: refs/heads/master@{#396977}
4 years, 6 months ago (2016-05-31 23:44:16 UTC) #9
scottmg
4 years, 6 months ago (2016-06-08 00:09:14 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2042213003/ by scottmg@chromium.org.

The reason for reverting is: Speculative revert for very small likelihood of
causing elevated crash rates as detailed in
https://bugs.chromium.org/p/chromium/issues/detail?id=616399.

Powered by Google App Engine
This is Rietveld 408576698