Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2027653003: [Telemetry] Move all logging of browser info from shared_page_state to browser's constructor (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Move all logging of browser info from shared_page_state to browser's constructor BUG=chromium:604791 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e288c0d9a188e99dead128f5d2669e86b995cb42

Patch Set 1 #

Patch Set 2 : Address Ken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M telemetry/telemetry/internal/browser/browser.py View 1 2 chunks +29 lines, -0 lines 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
nednguyen
PTAL
4 years, 6 months ago (2016-05-31 20:01:00 UTC) #2
Ken Russell (switch to Gerrit)
This looks like it only deletes the logging, not moves it. Am I missing something?
4 years, 6 months ago (2016-06-01 00:15:45 UTC) #3
nednguyen
On 2016/06/01 00:15:45, Ken Russell wrote: > This looks like it only deletes the logging, ...
4 years, 6 months ago (2016-06-01 00:20:01 UTC) #4
nednguyen
PTAL again
4 years, 6 months ago (2016-06-01 02:19:42 UTC) #5
Ken Russell (switch to Gerrit)
Thanks. LGTM if this has been tested.
4 years, 6 months ago (2016-06-01 02:26:37 UTC) #6
nednguyen
On 2016/06/01 02:26:37, Ken Russell wrote: > Thanks. LGTM if this has been tested. Umm, ...
4 years, 6 months ago (2016-06-01 02:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2027653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2027653003/20001
4 years, 6 months ago (2016-06-01 02:32:31 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 02:55:09 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698