Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: telemetry/telemetry/internal/browser/browser.py

Issue 2027653003: [Telemetry] Move all logging of browser info from shared_page_state to browser's constructor (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Address Ken's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/browser/browser.py
diff --git a/telemetry/telemetry/internal/browser/browser.py b/telemetry/telemetry/internal/browser/browser.py
index 2a1488f90a967d3dd1c2235bd265c0cd818c60a8..3c62362820f07a3ea2431ffe9cf798f308df4c1d 100644
--- a/telemetry/telemetry/internal/browser/browser.py
+++ b/telemetry/telemetry/internal/browser/browser.py
@@ -53,6 +53,7 @@ class Browser(app.App):
self._browser_backend.SetBrowser(self)
self._browser_backend.Start()
+ self._LogBrowserInfo()
self._platform_backend.DidStartBrowser(self, self._browser_backend)
self._profiling_controller = profiling_controller.ProfilingController(
self._browser_backend.profiling_controller_backend)
@@ -106,6 +107,34 @@ class Browser(app.App):
'Extensions not supported')
return extension_dict.ExtensionDict(self._browser_backend.extension_backend)
+ def _LogBrowserInfo(self):
+ logging.info('OS: %s %s',
+ self._platform_backend.platform.GetOSName(),
+ self._platform_backend.platform.GetOSVersionName())
+ if self.supports_system_info:
+ system_info = self.GetSystemInfo()
+ if system_info.model_name:
+ logging.info('Model: %s', system_info.model_name)
+ if system_info.gpu:
+ for i, device in enumerate(system_info.gpu.devices):
+ logging.info('GPU device %d: %s', i, device)
+ if system_info.gpu.aux_attributes:
+ logging.info('GPU Attributes:')
+ for k, v in sorted(system_info.gpu.aux_attributes.iteritems()):
+ logging.info(' %-20s: %s', k, v)
+ if system_info.gpu.feature_status:
+ logging.info('Feature Status:')
+ for k, v in sorted(system_info.gpu.feature_status.iteritems()):
+ logging.info(' %-20s: %s', k, v)
+ if system_info.gpu.driver_bug_workarounds:
+ logging.info('Driver Bug Workarounds:')
+ for workaround in system_info.gpu.driver_bug_workarounds:
+ logging.info(' %s', workaround)
+ else:
+ logging.info('No GPU devices')
+ else:
+ logging.warning('System info not supported')
+
def _GetStatsCommon(self, pid_stats_function):
browser_pid = self._browser_backend.pid
result = {
« no previous file with comments | « no previous file | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698