Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 2027653003: [Telemetry] Move all logging of browser info from shared_page_state to browser's constructor (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Address Ken's comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/browser/browser.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index 2e969edc696476ff820affbe404346a322b63572..0578b675da05fbe0a932e86e145617883b6bc381 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -190,32 +190,6 @@ class SharedPageState(story.SharedState):
if self._first_browser:
self._first_browser = False
self.browser.credentials.WarnIfMissingCredentials(page)
- logging.info('OS: %s %s',
- self.platform.GetOSName(),
- self.platform.GetOSVersionName())
- if self.browser.supports_system_info:
- system_info = self.browser.GetSystemInfo()
- if system_info.model_name:
- logging.info('Model: %s', system_info.model_name)
- if system_info.gpu:
- for i, device in enumerate(system_info.gpu.devices):
- logging.info('GPU device %d: %s', i, device)
- if system_info.gpu.aux_attributes:
- logging.info('GPU Attributes:')
- for k, v in sorted(system_info.gpu.aux_attributes.iteritems()):
- logging.info(' %-20s: %s', k, v)
- if system_info.gpu.feature_status:
- logging.info('Feature Status:')
- for k, v in sorted(system_info.gpu.feature_status.iteritems()):
- logging.info(' %-20s: %s', k, v)
- if system_info.gpu.driver_bug_workarounds:
- logging.info('Driver Bug Workarounds:')
- for workaround in system_info.gpu.driver_bug_workarounds:
- logging.info(' %s', workaround)
- else:
- logging.info('No GPU devices')
- else:
- logging.warning('System info not supported')
def WillRunStory(self, page):
if not self.platform.tracing_controller.is_tracing_running:
« no previous file with comments | « telemetry/telemetry/internal/browser/browser.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698