Handle uncommitted PaintController in DisplayItemClient aliveness tracking

Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1] https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D%27blink%3A%3ADisplayItemClient%3A%3A~DisplayItemClient%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=aa1bbf9c00000000&index=3#0

BUG=609218, 616700
Committed: https://crrev.com/8869774caff4ff15a7f3712a0ea7e616e3c8ed40
Cr-Commit-Position: refs/heads/master@{#397616}

[Xianzhu, 2016-06-03 00:54:10]

Description was changed from

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

BUG=609218,616700
==========

to

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

TBR=chrishtr@chromium.org,pdr@chromium.org
BUG=609218,616700
==========

[Xianzhu, 2016-06-03 00:55:52]

Description was changed from

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

TBR=chrishtr@chromium.org,pdr@chromium.org
BUG=609218,616700
==========

to

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

BUG=609218,616700
==========

[Xianzhu, 2016-06-03 00:56:10]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[Xianzhu, 2016-06-03 00:56:39]

Description was changed from

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

BUG=609218,616700
==========

to

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1]
https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D...

BUG=609218,616700
==========

[chrishtr, 2016-06-03 01:13:51]

lgtm

[Xianzhu, 2016-06-03 01:24:06]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-06-03 01:25:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2027333004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2027333004/1

[commit-bot: I haz the power, 2016-06-03 03:28:16]

Description was changed from

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1]
https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D...

BUG=609218,616700
==========

to

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1]
https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D...

BUG=609218,616700
==========

[commit-bot: I haz the power, 2016-06-03 03:28:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 03:29:52]

Description was changed from

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1]
https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D...

BUG=609218,616700
==========

to

==========
Handle uncommitted PaintController in DisplayItemClient aliveness tracking

crbug.com/616700 is a case that PaintController is not committed before
destructed.

Recent crash reports [1] also show crashes in
DisplayItemClient::~DisplayItemClient() not during painting, indicating
that we may have uncommitted PaintController when painting finishes.

Though uncommitted PaintController might be still a problem, this patch
tolerate the situation in DisplayItemClient aliveness tracking by
clearing the should-keep-alive registry when PaintController is
destructed and after a synchronized painting.

[1]
https://crash/browse?q=custom_data.ChromeCrashProto.magic_signature_1.name%3D...

BUG=609218,616700

Committed: https://crrev.com/8869774caff4ff15a7f3712a0ea7e616e3c8ed40
Cr-Commit-Position: refs/heads/master@{#397616}
==========

[commit-bot: I haz the power, 2016-06-03 03:29:53]

Patchset 1 (id:??) landed as
https://crrev.com/8869774caff4ff15a7f3712a0ea7e616e3c8ed40
Cr-Commit-Position: refs/heads/master@{#397616}