third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h - Issue 2027333004: Handle uncommitted PaintController in DisplayItemClient aliveness tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

Issue 2027333004: Handle uncommitted PaintController in DisplayItemClient aliveness tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

index 25a4ef52658767f6afff5991c5a8905c97bd590c..4a6bdbbb5f32c4ffd2ccd09b1b5e9bf0ed787f00 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

@@ -65,10 +65,11 @@ public:

bool isAlive() const;

// Called when any DisplayItem of this DisplayItemClient is added into PaintController

// using PaintController::createAndAppend().

- void beginShouldKeepAlive(const void* owner) const;

- // Clears all should-keep-alive DisplayItemClients. Called after PaintController commits

- // new display items.

- static void endShouldKeepAliveAllClients(const void* owner);

+ void beginShouldKeepAlive(const void* paintController) const;

+ // Clears all should-keep-alive DisplayItemClients of a PaintController. Called after

+ // PaintController commits new display items.

+ static void endShouldKeepAliveAllClients(const void* paintController);

+ static void endShouldKeepAliveAllClients();

#else

virtual ~DisplayItemClient() { }

#endif