Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2027333004: Handle uncommitted PaintController in DisplayItemClient aliveness tracking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2519 matching lines...) Expand 10 before | Expand all | Expand 10 after
2530 if (GraphicsLayer* layerForScrollCorner = view.compositor()->layerForScrollC orner()) { 2530 if (GraphicsLayer* layerForScrollCorner = view.compositor()->layerForScrollC orner()) {
2531 synchronizedPaintRecursively(layerForScrollCorner); 2531 synchronizedPaintRecursively(layerForScrollCorner);
2532 } 2532 }
2533 2533
2534 forAllNonThrottledFrameViews([](FrameView& frameView) { 2534 forAllNonThrottledFrameViews([](FrameView& frameView) {
2535 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean); 2535 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean);
2536 LayoutViewItem layoutViewItem = frameView.layoutViewItem(); 2536 LayoutViewItem layoutViewItem = frameView.layoutViewItem();
2537 if (!layoutViewItem.isNull()) 2537 if (!layoutViewItem.isNull())
2538 layoutViewItem.layer()->clearNeedsRepaintRecursively(); 2538 layoutViewItem.layer()->clearNeedsRepaintRecursively();
2539 }); 2539 });
2540
2541 #if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
2542 DisplayItemClient::endShouldKeepAliveAllClients();
2543 #endif
2540 } 2544 }
2541 2545
2542 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer) 2546 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
2543 { 2547 {
2544 if (graphicsLayer->drawsContent()) 2548 if (graphicsLayer->drawsContent())
2545 graphicsLayer->paint(nullptr); 2549 graphicsLayer->paint(nullptr);
2546 2550
2547 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2551 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2548 if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer()) 2552 if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer())
2549 synchronizedPaintRecursively(maskLayer); 2553 synchronizedPaintRecursively(maskLayer);
(...skipping 1585 matching lines...) Expand 10 before | Expand all | Expand 10 after
4135 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4139 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4136 } 4140 }
4137 4141
4138 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4142 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4139 { 4143 {
4140 ASSERT(!layoutViewItem().isNull()); 4144 ASSERT(!layoutViewItem().isNull());
4141 return *layoutView(); 4145 return *layoutView();
4142 } 4146 }
4143 4147
4144 } // namespace blink 4148 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698