xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp - Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@context_cleanup_3

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

diff --git a/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp b/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

index 128620c9f8770c3a740f5fb1cc57e5e1bac95e0b..f9027dce185ae656ec81ffce45f83f64402aa1dc 100644

--- a/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

+++ b/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

@@ -309,8 +309,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_OpenList(

if (iLength >= 1) {

std::unique_ptr<CFXJSE_Value> pValue(pArguments->GetValue(0));

if (FXJSE_Value_IsObject(pValue.get())) {

- pNode =

- static_cast<CXFA_Node*>(FXJSE_Value_ToObject(pValue.get(), nullptr));

+ pNode = pValue.get()->ToNode(nullptr);

} else if (FXJSE_Value_IsUTF8String(pValue.get())) {

CFX_ByteString bsString;

FXJSE_Value_ToUTF8String(pValue.get(), bsString);

@@ -507,8 +506,7 @@ void CScript_HostPseudoModel::Script_HostPseudoModel_SetFocus(