Remove FXJSE_Value_ToObject and call methods directly

xfa/fxjse/value.h

Index: xfa/fxjse/value.h
diff --git a/xfa/fxjse/value.h b/xfa/fxjse/value.h
index 362cd64ace8b0bc0b5832a24b15a53e2bd052fb2..0be028e5b250c135d0d686a54e64fdb1bdf954c8 100644
--- a/xfa/fxjse/value.h
+++ b/xfa/fxjse/value.h
@@ -9,6 +9,11 @@
 
 #include "xfa/fxjse/scope_inline.h"
 
+class CXFA_FM2JSContext;
+class CXFA_Node;
+class CXFA_Object;
+class CXFA_ThisProxy;
+
 class CFXJSE_Value {
  public:
   CFXJSE_Value(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {}
@@ -141,7 +146,11 @@ class CFXJSE_Value {
     v8::String::Utf8Value hStringVal(hString);
     szStrOutput = *hStringVal;
   }
-  CFXJSE_HostObject* ToObject(CFXJSE_Class* lpClass) const;
+  CFXJSE_HostObject* ToHostObject(CFXJSE_Class* lpClass) const;
+  CXFA_Object* ToObject(CFXJSE_Class* lpClass) const;

[Tom Sepez, 2016/06/01 20:17:58]

Layering violation.  I think you're stuck with ToHostObject() in this layer. 
You can make a helper function to do the other casts in the file where they are
used.

[dsinclair, 2016/06/01 20:34:31]

Why is this a violation? CXFA_Object is defined in xfa/fxfa/parser which is all
under the xfa/ tree so it should be accessible from here.

+  CXFA_Node* ToNode(CFXJSE_Class* lpClass) const;
+  CXFA_FM2JSContext* ToJSContext(CFXJSE_Class* lpClass) const;
+  CXFA_ThisProxy* ToProxy(CFXJSE_Class* lpClass) const;
 
   V8_INLINE void SetUndefined() {
     CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);