Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: xfa/fxfa/parser/xfa_script.h

Issue 2026993003: Remove FXJSE_Value_ToObject and call methods directly (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@context_cleanup_3
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxfa/parser/xfa_script.h
diff --git a/xfa/fxfa/parser/xfa_script.h b/xfa/fxfa/parser/xfa_script.h
index da348f7a36fb0a62139cfee2c59c288561cb825d..b04254eeeb6b9c0de4f26c7a83eb3710b45c00ca 100644
--- a/xfa/fxfa/parser/xfa_script.h
+++ b/xfa/fxfa/parser/xfa_script.h
@@ -47,10 +47,8 @@ class CXFA_ValueArray : public CFX_ArrayTemplate<CFXJSE_Value*> {
}
void GetAttributeObject(CXFA_ObjArray& objArray) {
- for (int32_t i = 0; i < GetSize(); i++) {
- objArray.Add(
- static_cast<CXFA_Object*>(FXJSE_Value_ToObject(GetAt(i), nullptr)));
- }
+ for (int32_t i = 0; i < GetSize(); i++)
+ objArray.Add(GetAt(i)->ToObject(nullptr));
}
v8::Isolate* m_pIsolate;

Powered by Google App Engine
This is Rietveld 408576698