Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2026973002: Moves ash/wm/common/resources back to ash (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves ash/wm/common/resources back to ash We decided on a different approach that doesn't require splitting these out. This is a revert of https://codereview.chromium.org/1994993003 . BUG=616265 TEST=none R=oshima@chromium.org, thestig@chromium.org Committed: https://crrev.com/023551943e5bd6ffcac03889a4338c69d0d42b34 Cr-Commit-Position: refs/heads/master@{#397033}

Patch Set 1 #

Patch Set 2 : delete revived file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -176 lines) Patch
M ash/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M ash/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_resources.gyp View 4 chunks +0 lines, -4 lines 0 comments Download
M ash/resources/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M ash/resources/ash_resources.grd View 2 chunks +12 lines, -0 lines 0 comments Download
A + ash/resources/default_100_percent/common/multi_window_resize_horizontal.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_center.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_left.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_right.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_top.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_center.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_left.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_right.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_top.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/common/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/wm/common/ash_wm_common.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/common/ash_wm_common_resources.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
M ash/wm/common/dock/docked_window_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D ash/wm/common/resources/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D ash/wm/common/resources/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/wm/common/resources/PRESUBMIT.py View 1 chunk +0 lines, -47 lines 0 comments Download
D ash/wm/common/resources/ash_wm_common_resources.grd View 1 chunk +0 lines, -31 lines 0 comments Download
D ash/wm/common/resources/default_100_percent/common/multi_window_resize_horizontal.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_center.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_top.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_100_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_center.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_top.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
D ash/wm/common/resources/default_200_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
M ash/wm/common/workspace/multi_window_resize_controller.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/common/workspace/phantom_window_controller.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mash/wm/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 6 months ago (2016-05-31 22:45:42 UTC) #1
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-31 22:59:50 UTC) #2
oshima
lgtm
4 years, 6 months ago (2016-06-01 00:14:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2026973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2026973002/20001
4 years, 6 months ago (2016-06-01 02:46:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-01 02:52:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 02:54:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/023551943e5bd6ffcac03889a4338c69d0d42b34
Cr-Commit-Position: refs/heads/master@{#397033}

Powered by Google App Engine
This is Rietveld 408576698