Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1994993003: Moves resources used by ash/wm/common to ash/wm/common/resources (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves resources used by ash/wm/common to ash/wm/common/resources BUG=603369 TEST=none R=oshima@chromium.org,thestig@chromium.org Committed: https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9 Cr-Commit-Position: refs/heads/master@{#394898}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : repack chrome #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -36 lines) Patch
M ash/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash_resources.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M ash/resources/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M ash/resources/ash_resources.grd View 2 chunks +0 lines, -12 lines 0 comments Download
D ash/resources/default_100_percent/common/multi_window_resize_horizontal.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_center.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_left.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_right.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_top.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
D ash/resources/default_100_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_center.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_left.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_right.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_top.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +2 lines, -1 line 2 comments Download
M ash/wm/common/BUILD.gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M ash/wm/common/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/common/ash_wm_common.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + ash/wm/common/ash_wm_common_resources.gyp View 1 chunk +7 lines, -7 lines 0 comments Download
M ash/wm/common/dock/docked_window_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A ash/wm/common/resources/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A + ash/wm/common/resources/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/wm/common/resources/PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A ash/wm/common/resources/ash_wm_common_resources.grd View 1 chunk +31 lines, -0 lines 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/multi_window_resize_horizontal.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_center.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_top.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_100_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/multi_window_resize_vertical.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_bottom.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_bottom_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_center.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_top.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_top_left.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/phantom_window_top_right.png View Binary file 0 comments Download
A + ash/wm/common/resources/default_200_percent/common/shelf/shelf_background.png View Binary file 0 comments Download
M ash/wm/common/workspace/multi_window_resize_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/common/workspace/phantom_window_controller.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/app/mash/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sky
thestig: tools/gritsettings/resource_ids oshima: the rest
4 years, 7 months ago (2016-05-19 22:27:49 UTC) #1
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-19 22:37:34 UTC) #2
oshima
lgtm https://codereview.chromium.org/1994993003/diff/40001/ash/shelf/shelf_widget.cc File ash/shelf/shelf_widget.cc (right): https://codereview.chromium.org/1994993003/diff/40001/ash/shelf/shelf_widget.cc#newcode455 ash/shelf/shelf_widget.cc:455: *rb->GetImageSkiaNamed(IDR_ASH_WM_COMMON_SHELF_BACKGROUND); It sounds a bit weird to have ...
4 years, 7 months ago (2016-05-19 22:48:55 UTC) #3
sky
https://codereview.chromium.org/1994993003/diff/40001/ash/shelf/shelf_widget.cc File ash/shelf/shelf_widget.cc (right): https://codereview.chromium.org/1994993003/diff/40001/ash/shelf/shelf_widget.cc#newcode455 ash/shelf/shelf_widget.cc:455: *rb->GetImageSkiaNamed(IDR_ASH_WM_COMMON_SHELF_BACKGROUND); On 2016/05/19 22:48:55, oshima wrote: > It sounds ...
4 years, 7 months ago (2016-05-19 22:56:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994993003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994993003/40001
4 years, 7 months ago (2016-05-19 22:58:38 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 23:16:26 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:17:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/455e12470494c9586e21f669c043157acdceb2a9
Cr-Commit-Position: refs/heads/master@{#394898}

Powered by Google App Engine
This is Rietveld 408576698