Record Rappor metrics even for constant permissions.

Record Rappor metrics even for constant permissions.

To track permission usages even for constant permissions, call
PermissionUmaUtil::PermissionRequested() for such permission types from
PermissionManager::RequestPermissions().

BUG=n/a

Committed: https://crrev.com/3c05527002aa08b318ed689e0bc7d838d49e7635
Cr-Commit-Position: refs/heads/master@{#397075}

[Takashi Toyoshima, 2016-05-31 08:05:17]

toyoshim@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Takashi Toyoshima, 2016-05-31 08:05:18]

Hi, can you take a look?

[mlamouri (slow - plz ping), 2016-05-31 15:40:04]

lgtm

https://codereview.chromium.org/2026663002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_manager.cc (right):

https://codereview.chromium.org/2026663002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_manager.cc:297: if
(IsConstantPermission(permission)) {
I think you could even remove the check. |GetPermissionContext| isn't expecting
to return |nullptr| in a normal situation so I wouldn't make this code more
complicated.

[Takashi Toyoshima, 2016-06-01 05:11:52]

https://codereview.chromium.org/2026663002/diff/20001/chrome/browser/permissi...
File chrome/browser/permissions/permission_manager.cc (right):

https://codereview.chromium.org/2026663002/diff/20001/chrome/browser/permissi...
chrome/browser/permissions/permission_manager.cc:297: if
(IsConstantPermission(permission)) {
On 2016/05/31 15:40:04, Mounir Lamouri (slow) wrote:
> I think you could even remove the check. |GetPermissionContext| isn't
expecting
> to return |nullptr| in a normal situation so I wouldn't make this code more
> complicated.

Done.

[Takashi Toyoshima, 2016-06-01 05:11:59]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-06-01 05:11:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2026663002/#ps40001
(title: "review #3")

[commit-bot: I haz the power, 2016-06-01 05:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2026663002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2026663002/40001

[commit-bot: I haz the power, 2016-06-01 07:23:46]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-01 07:24:59]

Description was changed from

==========
Record Rappor metrics even for constant permissions.

To track permission usages even for constant permissions, call
PermissionUmaUtil::PermissionRequested() for such permission types from
PermissionManager::RequestPermissions().

BUG=n/a
==========

to

==========
Record Rappor metrics even for constant permissions.

To track permission usages even for constant permissions, call
PermissionUmaUtil::PermissionRequested() for such permission types from
PermissionManager::RequestPermissions().

BUG=n/a

Committed: https://crrev.com/3c05527002aa08b318ed689e0bc7d838d49e7635
Cr-Commit-Position: refs/heads/master@{#397075}
==========

[commit-bot: I haz the power, 2016-06-01 07:25:00]

Patchset 3 (id:??) landed as
https://crrev.com/3c05527002aa08b318ed689e0bc7d838d49e7635
Cr-Commit-Position: refs/heads/master@{#397075}