Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3686)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2026663002: Record Rappor metrics even for constant permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #3 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index bd0b9318a3c62d8434c3cb310b47b90eb78697e8..43470736f50dabfdb9d9cc31ac9c5d57796321e8 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -193,6 +193,12 @@ void RecordPermissionRequest(PermissionType permission,
"ContentSettings.PermissionRequested.Notifications.Url2",
rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
+ } else if (permission == PermissionType::MIDI ||
+ permission == PermissionType::MIDI_SYSEX) {
+ rappor::SampleDomainAndRegistryFromGURL(
+ rappor_service,
+ "ContentSettings.PermissionRequested.Midi.Url",
+ requesting_origin);
}
}
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698