Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2026663002: Record Rappor metrics even for constant permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #3 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 } else if (permission == PermissionType::NOTIFICATIONS) { 186 } else if (permission == PermissionType::NOTIFICATIONS) {
187 // TODO(dominickn): remove this deprecated metric - crbug.com/605836. 187 // TODO(dominickn): remove this deprecated metric - crbug.com/605836.
188 rappor::SampleDomainAndRegistryFromGURL( 188 rappor::SampleDomainAndRegistryFromGURL(
189 rappor_service, 189 rappor_service,
190 "ContentSettings.PermissionRequested.Notifications.Url", 190 "ContentSettings.PermissionRequested.Notifications.Url",
191 requesting_origin); 191 requesting_origin);
192 rappor_service->RecordSample( 192 rappor_service->RecordSample(
193 "ContentSettings.PermissionRequested.Notifications.Url2", 193 "ContentSettings.PermissionRequested.Notifications.Url2",
194 rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE, 194 rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
195 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin)); 195 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
196 } else if (permission == PermissionType::MIDI ||
197 permission == PermissionType::MIDI_SYSEX) {
198 rappor::SampleDomainAndRegistryFromGURL(
199 rappor_service,
200 "ContentSettings.PermissionRequested.Midi.Url",
201 requesting_origin);
196 } 202 }
197 } 203 }
198 204
199 bool secure_origin = content::IsOriginSecure(requesting_origin); 205 bool secure_origin = content::IsOriginSecure(requesting_origin);
200 UMA_HISTOGRAM_ENUMERATION( 206 UMA_HISTOGRAM_ENUMERATION(
201 "ContentSettings.PermissionRequested", 207 "ContentSettings.PermissionRequested",
202 static_cast<base::HistogramBase::Sample>(permission), 208 static_cast<base::HistogramBase::Sample>(permission),
203 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 209 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
204 if (secure_origin) { 210 if (secure_origin) {
205 UMA_HISTOGRAM_ENUMERATION( 211 UMA_HISTOGRAM_ENUMERATION(
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 } 362 }
357 363
358 void PermissionUmaUtil::PermissionPromptDenied( 364 void PermissionUmaUtil::PermissionPromptDenied(
359 const std::vector<PermissionBubbleRequest*>& requests) { 365 const std::vector<PermissionBubbleRequest*>& requests) {
360 DCHECK(!requests.empty()); 366 DCHECK(!requests.empty());
361 DCHECK(requests.size() == 1); 367 DCHECK(requests.size() == 1);
362 368
363 PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied, 369 PERMISSION_BUBBLE_TYPE_UMA(kPermissionsPromptDenied,
364 requests[0]->GetPermissionBubbleType()); 370 requests[0]->GetPermissionBubbleType());
365 } 371 }
OLDNEW
« no previous file with comments | « chrome/browser/permissions/permission_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698