content/renderer/media/rtc_video_encoder.cc - Issue 2026253003: Migrate WaitableEvent to enum-based constructor in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_encoder.cc

Issue 2026253003: Migrate WaitableEvent to enum-based constructor in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WEvent_enums

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_video_decoder_unittest.cc ('k') | content/renderer/media/webrtc/peer_connection_dependency_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_encoder.cc

diff --git a/content/renderer/media/rtc_video_encoder.cc b/content/renderer/media/rtc_video_encoder.cc

index 103e0c102b07a0413ffd35ffe174ec67e688bc1d..3e5a1b25bc51e2ef0152e9be6272ec6005612543 100644

--- a/content/renderer/media/rtc_video_encoder.cc

+++ b/content/renderer/media/rtc_video_encoder.cc

@@ -740,7 +740,9 @@ int32_t RTCVideoEncoder::InitEncode(const webrtc::VideoCodec* codec_settings,

const media::VideoCodecProfile profile = WebRTCVideoCodecToVideoCodecProfile(

impl_->video_codec_type(), codec_settings);

- base::WaitableEvent initialization_waiter(true, false);

+ base::WaitableEvent initialization_waiter(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

int32_t initialization_retval = WEBRTC_VIDEO_CODEC_UNINITIALIZED;

gpu_task_runner_->PostTask(

FROM_HERE,

@@ -770,7 +772,9 @@ int32_t RTCVideoEncoder::Encode(

const bool want_key_frame = frame_types && frame_types->size() &&

frame_types->front() == webrtc::kVideoFrameKey;

- base::WaitableEvent encode_waiter(true, false);

+ base::WaitableEvent encode_waiter(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

int32_t encode_retval = WEBRTC_VIDEO_CODEC_UNINITIALIZED;

gpu_task_runner_->PostTask(

FROM_HERE,

@@ -795,7 +799,9 @@ int32_t RTCVideoEncoder::RegisterEncodeCompleteCallback(

return WEBRTC_VIDEO_CODEC_UNINITIALIZED;

}

- base::WaitableEvent register_waiter(true, false);

+ base::WaitableEvent register_waiter(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

int32_t register_retval = WEBRTC_VIDEO_CODEC_UNINITIALIZED;

gpu_task_runner_->PostTask(

FROM_HERE,

@@ -810,7 +816,9 @@ int32_t RTCVideoEncoder::Release() {

if (!impl_.get())

return WEBRTC_VIDEO_CODEC_OK;

- base::WaitableEvent release_waiter(true, false);

+ base::WaitableEvent release_waiter(

+ base::WaitableEvent::ResetPolicy::MANUAL,

+ base::WaitableEvent::InitialState::NOT_SIGNALED);

gpu_task_runner_->PostTask(

FROM_HERE,

base::Bind(&RTCVideoEncoder::Impl::Destroy, impl_, &release_waiter));