content/browser/service_worker/service_worker_metrics.cc - Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove comma Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_metrics.h ('K') | « content/browser/service_worker/service_worker_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_metrics.cc

diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc

index a481b8bf03589ba0fdd19e209b76e7c869d1b9fe..69090e3df938a5c8a15c2fcb1c25f652894067f6 100644

--- a/content/browser/service_worker/service_worker_metrics.cc

+++ b/content/browser/service_worker/service_worker_metrics.cc

@@ -172,8 +172,12 @@ void ServiceWorkerMetrics::RecordDeleteAndStartOverResult(

result, NUM_DELETE_AND_START_OVER_RESULT_TYPES);

}

-void ServiceWorkerMetrics::CountControlledPageLoad(const GURL& url) {

+void ServiceWorkerMetrics::CountControlledPageLoad(const GURL& url,

+ bool has_fetch_handler) {

Site site = SiteFromURL(url);

+ if (site == Site::OTHER)

+ site = (has_fetch_handler) ? Site::WITH_FETCH_HANDLER

+ : Site::WITHOUT_FETCH_HANDLER;

falken 2016/05/31 08:38:55 nit: prefer braces here for multi-line if body

shimazu 2016/05/31 09:11:42 Done.

UMA_HISTOGRAM_ENUMERATION("ServiceWorker.PageLoad", static_cast<int>(site),

static_cast<int>(Site::NUM_TYPES));