Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 2025813002: ServiceWorker: Distinguish SW.PageLoad w/ and w/o fetch handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove comma Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.h
diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h
index dd2372ad316cfdb951e9fc82e61debfc0e62eea2..159a3352d1b23e5f21d6b4d901872bd584eae3cb 100644
--- a/content/browser/service_worker/service_worker_metrics.h
+++ b/content/browser/service_worker/service_worker_metrics.h
@@ -100,7 +100,13 @@ class ServiceWorkerMetrics {
};
// Used for UMA. Append only.
- enum class Site { OTHER, NEW_TAB_PAGE, NUM_TYPES };
+ enum class Site {
+ OTHER,
falken 2016/05/31 08:38:55 Add a comment that this is obsolete.
shimazu 2016/05/31 09:11:42 Done.
+ NEW_TAB_PAGE,
+ WITH_FETCH_HANDLER,
+ WITHOUT_FETCH_HANDLER,
+ NUM_TYPES
+ };
// Not used for UMA.
enum class StartSituation {
@@ -138,7 +144,7 @@ class ServiceWorkerMetrics {
static void RecordDeleteAndStartOverResult(DeleteAndStartOverResult result);
// Counts the number of page loads controlled by a Service Worker.
- static void CountControlledPageLoad(const GURL& url);
+ static void CountControlledPageLoad(const GURL& url, bool has_fetch_handler);
// Records the result of trying to start a worker. |is_installed| indicates
// whether the version has been installed.

Powered by Google App Engine
This is Rietveld 408576698