Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2025393003: Move document.visualViewport to window.visualViewport (Closed)

Created:
4 years, 6 months ago by bokan
Modified:
4 years, 6 months ago
Reviewers:
ymalik
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move document.visualViewport to window.visualViewport The `window` object is a more natural place for the visualViewport API. The original concern was causing breaking changes since this would clash with any variable in the global scrope called `visualViewport` but a search through httpArchive found that this is unlikely to be an issue. BUG=595826 Committed: https://crrev.com/900d90568dd674bd31fa0a5b25fa4b368e9c67ae Cr-Commit-Position: refs/heads/master@{#397845}

Patch Set 1 #

Patch Set 2 : Fixing expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -86 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html View 1 chunk +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions-expected.txt View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-custom-scrollbars.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-exclude-scrollbars.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html View 1 chunk +19 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/visualviewportchanged-event-fired.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bokan
4 years, 6 months ago (2016-06-02 18:28:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025393003/1
4 years, 6 months ago (2016-06-02 18:29:02 UTC) #5
ymalik
lgtm
4 years, 6 months ago (2016-06-02 19:10:55 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/238085)
4 years, 6 months ago (2016-06-02 20:15:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025393003/20001
4 years, 6 months ago (2016-06-03 19:07:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 23:47:52 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 23:49:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/900d90568dd674bd31fa0a5b25fa4b368e9c67ae
Cr-Commit-Position: refs/heads/master@{#397845}

Powered by Google App Engine
This is Rietveld 408576698