Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html

Issue 2025393003: Move document.visualViewport to window.visualViewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing expectations Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
index 89c4911366dfd27141bc9be3d7fccb0ef6851b81..b90286add9ea34fd791ff436391836d0053469f1 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html
@@ -23,33 +23,33 @@
internals.setPageScaleFactor(2);
// Offset visual viewport by 10px.
- document.visualViewport.scrollTop = 10;
- document.visualViewport.scrollLeft = 10;
+ window.visualViewport.scrollTop = 10;
+ window.visualViewport.scrollLeft = 10;
- assert_equals(document.visualViewport.scrollTop, 10);
- assert_equals(document.visualViewport.scrollLeft, 10);
- assert_equals(document.visualViewport.clientWidth, 400);
- assert_equals(document.visualViewport.clientHeight, 300);
- assert_equals(document.visualViewport.pageScale, 2);
+ assert_equals(window.visualViewport.scrollTop, 10);
+ assert_equals(window.visualViewport.scrollLeft, 10);
+ assert_equals(window.visualViewport.clientWidth, 400);
+ assert_equals(window.visualViewport.clientHeight, 300);
+ assert_equals(window.visualViewport.pageScale, 2);
// Apply browser zoom.
window.internals.setZoomFactor(browserZoomFactor);
// Visual viewport dimensions should be scaled by the browser zoom factor.
- assert_equals(document.visualViewport.scrollTop, 10 / browserZoomFactor);
- assert_equals(document.visualViewport.scrollLeft, 10 / browserZoomFactor);
- assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor);
- assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFactor);
- assert_equals(document.visualViewport.pageScale, 2);
+ assert_equals(window.visualViewport.scrollTop, 10 / browserZoomFactor);
+ assert_equals(window.visualViewport.scrollLeft, 10 / browserZoomFactor);
+ assert_equals(window.visualViewport.clientWidth, 400 / browserZoomFactor);
+ assert_equals(window.visualViewport.clientHeight, 300 / browserZoomFactor);
+ assert_equals(window.visualViewport.pageScale, 2);
// Verify setting the visual viewport offset under browser zoom.
- document.visualViewport.scrollTop = 12.5;
- document.visualViewport.scrollLeft = 12.5;
- assert_equals(document.visualViewport.scrollTop, 12.5);
- assert_equals(document.visualViewport.scrollLeft, 12.5);
- assert_equals(document.visualViewport.clientWidth, 400 / browserZoomFactor);
- assert_equals(document.visualViewport.clientHeight, 300 / browserZoomFactor);
- assert_equals(document.visualViewport.pageScale, 2);
+ window.visualViewport.scrollTop = 12.5;
+ window.visualViewport.scrollLeft = 12.5;
+ assert_equals(window.visualViewport.scrollTop, 12.5);
+ assert_equals(window.visualViewport.scrollLeft, 12.5);
+ assert_equals(window.visualViewport.clientWidth, 400 / browserZoomFactor);
+ assert_equals(window.visualViewport.clientHeight, 300 / browserZoomFactor);
+ assert_equals(window.visualViewport.pageScale, 2);
t.done();
});
}, 'Verify viewport dimensions under bowser zoom.');

Powered by Google App Engine
This is Rietveld 408576698