Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

Issue 2025393003: Move document.visualViewport to window.visualViewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing expectations Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html
index 4b04b85946be4a955cca770be41faa38db6d70a9..9159b5a1a14ae54975ce74d23675860fbc4425fe 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html
@@ -31,32 +31,32 @@
eventSender.continuousMouseScrollBy(100, 100);
debug(" **** Initial visual viewport dimensions *****");
- shouldBe("document.visualViewport.scrollTop", "0");
- shouldBe("document.visualViewport.scrollLeft", "0");
- shouldBe("document.visualViewport.clientWidth", "800");
- shouldBe("document.visualViewport.clientHeight", "600");
- shouldBe("document.visualViewport.pageScale", "1");
+ shouldBe("window.visualViewport.scrollTop", "0");
+ shouldBe("window.visualViewport.scrollLeft", "0");
+ shouldBe("window.visualViewport.clientWidth", "800");
+ shouldBe("window.visualViewport.clientHeight", "600");
+ shouldBe("window.visualViewport.pageScale", "1");
// Scale and scroll visual viewport.
internals.setPageScaleFactor(2);
internals.setVisualViewportOffset(10, 10);
debug(" **** Viewport dimensions after scale and scroll *****");
- shouldBe("document.visualViewport.scrollTop", "10");
- shouldBe("document.visualViewport.scrollLeft", "10");
- shouldBe("document.visualViewport.clientWidth", "400");
- shouldBe("document.visualViewport.clientHeight", "300");
- shouldBe("document.visualViewport.pageScale", "2");
+ shouldBe("window.visualViewport.scrollTop", "10");
+ shouldBe("window.visualViewport.scrollLeft", "10");
+ shouldBe("window.visualViewport.clientWidth", "400");
+ shouldBe("window.visualViewport.clientHeight", "300");
+ shouldBe("window.visualViewport.pageScale", "2");
- document.visualViewport.scrollTop = 20;
- document.visualViewport.scrollLeft = 0;
+ window.visualViewport.scrollTop = 20;
+ window.visualViewport.scrollLeft = 0;
debug(" **** Writable viewport dimensions *****");
- shouldBe("document.visualViewport.scrollTop", "20");
- shouldBe("document.visualViewport.scrollLeft", "0");
- document.visualViewport.scrollTop = -20;
- shouldBe("document.visualViewport.scrollTop", "0");
- document.visualViewport.scrollTop = 20.5;
- shouldBe("document.visualViewport.scrollTop", "20.5");
+ shouldBe("window.visualViewport.scrollTop", "20");
+ shouldBe("window.visualViewport.scrollLeft", "0");
+ window.visualViewport.scrollTop = -20;
+ shouldBe("window.visualViewport.scrollTop", "0");
+ window.visualViewport.scrollTop = 20.5;
+ shouldBe("window.visualViewport.scrollTop", "20.5");
finishJSTest();
}

Powered by Google App Engine
This is Rietveld 408576698