Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20253002: core/rendering: Include wtf files using "wtf/foo.h" form. (Closed)

Created:
7 years, 5 months ago by tfarina
Modified:
7 years, 5 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, chromiumbugtracker_adobe.com, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Visibility:
Public.

Description

core/rendering: Include wtf files using "wtf/foo.h" form. Instead of including them as: \#include <wtf/foo.h> Change it to include as: \#include "wtf/foo.h" Patch generated with thakis's script: git grep -l '#include <wtf' Source/core/rendering | xargs sed -i -e 's/#include <\(wtf\/[^>]*\)>/#include "\1"/' BUG=254653 R=abarth@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154941

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -234 lines) Patch
M Source/core/rendering/AutoTableLayout.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/BidiRun.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/BidiRun.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/ClipPathOperation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/ColumnInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/CounterNode.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/FixedTableLayout.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/FlowThreadController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/FlowThreadController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestLocation.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/HitTestResult.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/HitTestingTransformState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/HitTestingTransformState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/ImageQualityController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/LayoutState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/PaintInfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderArena.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxRegionInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderNamedFlowThread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObjectChildList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderProgress.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderRuby.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarTheme.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTextControl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProvider.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProviderLinux.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/TableLayout.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/TextAutosizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/rendering/VerticalPositionCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/break_lines.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/break_lines.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/ContentData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/CounterContent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/CounterDirectives.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/rendering/style/CounterDirectives.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/CursorList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/DataRef.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/FillLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/KeyframeList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/QuotesData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/SVGRenderStyleDefs.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/ShadowData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleBackgroundData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleBoxData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleCustomFilterProgramCache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleDeprecatedFlexibleBoxData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleFilterData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleFlexibleBoxData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleGridData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleGridItemData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleInheritedData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleMarqueeData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleMultiColData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StylePendingShader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleReflection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleShader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleSurroundData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleTransformData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleVariableData.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/StyleVisualData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGMarkerData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGPathData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResources.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGResourcesCycleSolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGSubpathData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextChunkBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributes.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributes.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutAttributesBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngineBaseline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngineSpacing.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextMetrics.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextMetricsBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextQuery.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 5 months ago (2013-07-25 04:33:26 UTC) #1
tfarina
7 years, 5 months ago (2013-07-25 04:33:40 UTC) #2
Nico
lgtm https://codereview.chromium.org/20253002/diff/1/Source/core/rendering/FilterEffectRenderer.h File Source/core/rendering/FilterEffectRenderer.h (right): https://codereview.chromium.org/20253002/diff/1/Source/core/rendering/FilterEffectRenderer.h#newcode39 Source/core/rendering/FilterEffectRenderer.h:39: nit: remove newline https://codereview.chromium.org/20253002/diff/1/Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp File Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp (right): https://codereview.chromium.org/20253002/diff/1/Source/core/rendering/RenderThemeChromiumFontProviderWin.cpp#newcode29 ...
7 years, 5 months ago (2013-07-25 17:56:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/20253002/7001
7 years, 5 months ago (2013-07-25 19:39:27 UTC) #4
tfarina
https://chromiumcodereview.appspot.com/20253002/diff/1/Source/core/rendering/FilterEffectRenderer.h File Source/core/rendering/FilterEffectRenderer.h (right): https://chromiumcodereview.appspot.com/20253002/diff/1/Source/core/rendering/FilterEffectRenderer.h#newcode39 Source/core/rendering/FilterEffectRenderer.h:39: On 2013/07/25 17:56:14, Nico wrote: > nit: remove newline ...
7 years, 5 months ago (2013-07-25 20:18:33 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-25 22:17:57 UTC) #6
Message was sent while issue was closed. 
Change committed as 154941

Powered by Google App Engine
This is Rietveld 408576698