Remove invalid fence order DCHECKs

Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fe743e092899ce7b7e36d90f3a2a1035ee3e57d7
Cr-Commit-Position: refs/heads/master@{#397057}

[piman, 2016-06-01 01:50:21]

Description was changed from

==========
Remove invalid DCHECK in SyncPointClientState::ReleaseFenceSync

The DCHECK tests client behavior, which is untrusted. DLOG_IF instead.

BUG=None
==========

to

==========
Remove invalid DCHECK in SyncPointClientState::ReleaseFenceSync

The DCHECK tests client behavior, which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-06-01 01:50:27]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[piman, 2016-06-01 01:50:32]

piman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[commit-bot: I haz the power, 2016-06-01 01:51:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025223002/1

[sunnyps, 2016-06-01 01:54:53]

Might make sense going through
https://bugs.chromium.org/p/chromium/issues/detail?id=606112 and removing all
the checks added there for debugging.

Otherwise LGTM

[piman, 2016-06-01 03:03:41]

Description was changed from

==========
Remove invalid DCHECK in SyncPointClientState::ReleaseFenceSync

The DCHECK tests client behavior, which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-06-01 03:04:35]

On 2016/06/01 01:54:53, sunnyps wrote:
> Might make sense going through
> https://bugs.chromium.org/p/chromium/issues/detail?id=606112 and removing all
> the checks added there for debugging.

I removed another DCHECK in GpuCommandBufferStub, which is also invalid. I'm
leaving client-side DCHECKs (e.g. thread checkers) which are valid, and could be
useful to catch regressions.

> 
> Otherwise LGTM

[piman, 2016-06-01 03:04:43]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 03:05:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025223002/20001

[commit-bot: I haz the power, 2016-06-01 04:25:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 04:25:58]

Dry run: This issue passed the CQ dry run.

[piman, 2016-06-01 04:31:27]

The CQ bit was checked by piman@chromium.org

[piman, 2016-06-01 04:31:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org
Link to the patchset: https://codereview.chromium.org/2025223002/#ps20001
(title: "also remove DCHECK from GpuCommandBufferStub::OnCreateImage")

[commit-bot: I haz the power, 2016-06-01 04:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2025223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2025223002/20001

[commit-bot: I haz the power, 2016-06-01 04:35:52]

Description was changed from

==========
Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-01 04:35:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 04:38:09]

Description was changed from

==========
Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove invalid fence order DCHECKs

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fe743e092899ce7b7e36d90f3a2a1035ee3e57d7
Cr-Commit-Position: refs/heads/master@{#397057}
==========

[commit-bot: I haz the power, 2016-06-01 04:38:10]

Patchset 2 (id:??) landed as
https://crrev.com/fe743e092899ce7b7e36d90f3a2a1035ee3e57d7
Cr-Commit-Position: refs/heads/master@{#397057}