Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: gpu/ipc/service/gpu_command_buffer_stub.cc

Issue 2025223002: Remove invalid fence order DCHECKs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: also remove DCHECK from GpuCommandBufferStub::OnCreateImage Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/sync_point_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/ipc/service/gpu_command_buffer_stub.h" 5 #include "gpu/ipc/service/gpu_command_buffer_stub.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 972 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 return; 983 return;
984 } 984 }
985 985
986 scoped_refptr<gl::GLImage> image = channel()->CreateImageForGpuMemoryBuffer( 986 scoped_refptr<gl::GLImage> image = channel()->CreateImageForGpuMemoryBuffer(
987 handle, size, format, internalformat); 987 handle, size, format, internalformat);
988 if (!image.get()) 988 if (!image.get())
989 return; 989 return;
990 990
991 image_manager->AddImage(image.get(), id); 991 image_manager->AddImage(image.get(), id);
992 if (image_release_count) { 992 if (image_release_count) {
993 DCHECK_EQ(image_release_count, 993 DLOG_IF(ERROR,
994 sync_point_client_->client_state()->fence_sync_release() + 1); 994 image_release_count !=
995 sync_point_client_->client_state()->fence_sync_release() + 1)
996 << "Client released fences out of order.";
995 sync_point_client_->ReleaseFenceSync(image_release_count); 997 sync_point_client_->ReleaseFenceSync(image_release_count);
996 } 998 }
997 } 999 }
998 1000
999 void GpuCommandBufferStub::OnDestroyImage(int32_t id) { 1001 void GpuCommandBufferStub::OnDestroyImage(int32_t id) {
1000 TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyImage"); 1002 TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyImage");
1001 1003
1002 if (!decoder_) 1004 if (!decoder_)
1003 return; 1005 return;
1004 1006
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1090 Send(new GpuCommandBufferMsg_SwapBuffersCompleted(route_id_, params)); 1092 Send(new GpuCommandBufferMsg_SwapBuffersCompleted(route_id_, params));
1091 } 1093 }
1092 1094
1093 void GpuCommandBufferStub::SendUpdateVSyncParameters(base::TimeTicks timebase, 1095 void GpuCommandBufferStub::SendUpdateVSyncParameters(base::TimeTicks timebase,
1094 base::TimeDelta interval) { 1096 base::TimeDelta interval) {
1095 Send(new GpuCommandBufferMsg_UpdateVSyncParameters(route_id_, timebase, 1097 Send(new GpuCommandBufferMsg_UpdateVSyncParameters(route_id_, timebase,
1096 interval)); 1098 interval));
1097 } 1099 }
1098 1100
1099 } // namespace gpu 1101 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/sync_point_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698