gpu/command_buffer/service/sync_point_manager.cc - Issue 2025223002: Remove invalid fence order DCHECKs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/sync_point_manager.cc

Issue 2025223002: Remove invalid fence order DCHECKs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also remove DCHECK from GpuCommandBufferStub::OnCreateImage Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/sync_point_manager.cc

diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc

index 022895ad494cee566cd9cb29abced9f12eb79477..04a92e015b6e3264591115700e2819a5a6cce5c3 100644

--- a/gpu/command_buffer/service/sync_point_manager.cc

+++ b/gpu/command_buffer/service/sync_point_manager.cc

@@ -232,7 +232,8 @@ void SyncPointClientState::ReleaseFenceSync(uint64_t release) {

std::vector<base::Closure> callback_list;

{

base::AutoLock auto_lock(fence_sync_lock_);

- DCHECK_GT(release, fence_sync_release_);

+ DLOG_IF(ERROR, release <= fence_sync_release_)

+ << "Client submitted fence releases out of order.";

fence_sync_release_ = release;

while (!release_callback_queue_.empty() &&

« no previous file with comments | « no previous file | gpu/ipc/service/gpu_command_buffer_stub.cc » ('j') | no next file with comments »