Add CrossThreadCopier and isolatedCopy() to SourceLocation.

Add CrossThreadCopier and isolatedCopy() to SourceLocation.

We have to make isolatedCopy of every WTF::String when passing
SourceLocation between threads.

This fixes data race introduced by https://codereview.chromium.org/2010603002.

BUG=615712
Committed: https://crrev.com/48e31ee8f0d774b8674b90a7167e648ada24292c
Cr-Commit-Position: refs/heads/master@{#397137}

[dgozman, 2016-05-31 23:07:24]

dgozman@chromium.org changed reviewers:
+ haraken@chromium.org, sigbjornf@opera.com

[dgozman, 2016-05-31 23:07:25]

@sigbjornf: could you please take a look?

+haraken for bindings/ owner.

[haraken, 2016-05-31 23:37:01]

LGTM

[sof, 2016-06-01 05:11:30]

lgtm too

[dgozman, 2016-06-01 05:23:05]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-06-01 05:23:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024993003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024993003/1

[commit-bot: I haz the power, 2016-06-01 10:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 10:50:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sof, 2016-06-01 12:39:47]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-06-01 12:40:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024993003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024993003/1

[commit-bot: I haz the power, 2016-06-01 14:31:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-01 14:32:47]

Description was changed from

==========
Add CrossThreadCopier and isolatedCopy() to SourceLocation.

We have to make isolatedCopy of every WTF::String when passing
SourceLocation between threads.

This fixes data race introduced by https://codereview.chromium.org/2010603002.

BUG=615712
==========

to

==========
Add CrossThreadCopier and isolatedCopy() to SourceLocation.

We have to make isolatedCopy of every WTF::String when passing
SourceLocation between threads.

This fixes data race introduced by https://codereview.chromium.org/2010603002.

BUG=615712

Committed: https://crrev.com/48e31ee8f0d774b8674b90a7167e648ada24292c
Cr-Commit-Position: refs/heads/master@{#397137}
==========

[commit-bot: I haz the power, 2016-06-01 14:32:48]

Patchset 1 (id:??) landed as
https://crrev.com/48e31ee8f0d774b8674b90a7167e648ada24292c
Cr-Commit-Position: refs/heads/master@{#397137}

[pfeldman, 2016-06-08 02:22:17]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-06-08 02:22:18]

https://codereview.chromium.org/2024993003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
(right):

https://codereview.chromium.org/2024993003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp:90: return
Frame(m_functionName.isolatedCopy(), m_scriptId.isolatedCopy(),
m_scriptName.isolatedCopy(), m_lineNumber, m_columnNumber);
We should not pass this struct between threads at all.