Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2016123002: Remove ScriptCallStack. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, caseq+blink_chromium.org, yhirano+watch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-worker-reviews_chromium.org, sof, lushnikov+blink_chromium.org, haraken, mkwst+watchlist-csp_chromium.org, tyoshino+watch_chromium.org, falken, pfeldman+blink_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2006893004
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScriptCallStack. It is superseded by SourceLocation now. BUG=613882 Committed: https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c Cr-Commit-Position: refs/heads/master@{#397163}

Patch Set 1 #

Patch Set 2 : full stack trace #

Total comments: 4

Patch Set 3 : fixed review comment #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -362 lines) Patch
D third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.h View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/ScriptCallStack.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 1 2 3 2 chunks +18 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp View 1 2 3 6 chunks +35 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameConsole.cpp View 1 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.h View 3 chunks +9 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp View 5 chunks +9 lines, -67 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 2 3 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPepperSocketImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2024993003 Patch 1

Messages

Total messages: 18 (7 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-05-26 22:46:16 UTC) #2
dgozman
Aleksey, take a look please!
4 years, 7 months ago (2016-05-26 22:48:22 UTC) #4
kozy
lgtm % nit & deleting getFunctionLocation https://codereview.chromium.org/2016123002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/2016123002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp#newcode726 third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:726: OwnPtr<SourceLocation> location = ...
4 years, 6 months ago (2016-05-27 00:44:16 UTC) #5
dgozman
https://codereview.chromium.org/2016123002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/2016123002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp#newcode726 third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:726: OwnPtr<SourceLocation> location = SourceLocation::fromFunction(originalFunction); On 2016/05/27 00:44:16, kozyatinskiy wrote: ...
4 years, 6 months ago (2016-05-27 00:52:29 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016123002/40001
4 years, 6 months ago (2016-05-27 01:42:12 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 03:31:57 UTC) #10
dgozman
Pavel, PTAL.
4 years, 6 months ago (2016-05-27 04:58:01 UTC) #11
pfeldman
lgtm
4 years, 6 months ago (2016-05-31 19:15:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2016123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2016123002/60001
4 years, 6 months ago (2016-06-01 15:20:34 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 17:03:46 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 17:05:05 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6dfba9844c8d7446353d61953d0361e2efdb1e4c
Cr-Commit-Position: refs/heads/master@{#397163}

Powered by Google App Engine
This is Rietveld 408576698