third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h - Issue 2024993003: Add CrossThreadCopier and isolatedCopy() to SourceLocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2024993003: Add CrossThreadCopier and isolatedCopy() to SourceLocation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

index cecdab1b4ac9660a49049f6684e7821c3545fe96..23e169700da5f041a405126f29bbf30da74d65cf 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

@@ -31,6 +31,7 @@ public:

const String16& sourceURL() const { return m_scriptName; }

int lineNumber() const { return m_lineNumber; }

int columnNumber() const { return m_columnNumber; }

+ Frame isolatedCopy() const;

private:

friend class V8StackTraceImpl;

@@ -49,6 +50,8 @@ public:

std::unique_ptr<V8StackTrace> clone() override;

std::unique_ptr<V8StackTraceImpl> cloneImpl();

+ std::unique_ptr<V8StackTrace> isolatedCopy() override;

+ std::unique_ptr<V8StackTraceImpl> isolatedCopyImpl();

std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V8DebuggerAgentImpl*) const;

~V8StackTraceImpl() override;