Motown: Move framework/util/incident* so other services can use it

Motown: Move framework/util/incident* so other services can use it
plus minor change to factory_service_base.

R=kulakowski@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/bf706cda177cb451d8ca624cd21cfff8e91bcfdb

[dalesat, 2016-05-31 17:24:55]

Description was changed from

==========
Motown: Move framework/util/incident* so other services can use it
plus minor change to factory_service_base.
==========

to

==========
Motown: Move framework/util/incident* so other services can use it
plus minor change to factory_service_base.
==========

[dalesat, 2016-05-31 17:24:55]

dalesat@chromium.org changed reviewers:
+ kulakowski@chromium.org

[dalesat, 2016-05-31 17:25:07]

Please take a look. Thanks!

[kulakowski, 2016-05-31 20:00:47]

lgtm

[dalesat, 2016-05-31 22:21:19]

Description was changed from

==========
Motown: Move framework/util/incident* so other services can use it
plus minor change to factory_service_base.
==========

to

==========
Motown: Move framework/util/incident* so other services can use it
plus minor change to factory_service_base.

R=kulakowski@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/bf706cda177cb451d8ca624cd21...
==========

[dalesat, 2016-05-31 22:21:21]

Committed patchset #1 (id:1) manually as
bf706cda177cb451d8ca624cd21cfff8e91bcfdb (presubmit successful).

[viettrungluu, 2016-05-31 23:37:01]

viettrungluu@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2016-05-31 23:37:01]

https://codereview.chromium.org/2024953003/diff/1/services/util/cpp/test/test...
File services/util/cpp/test/test_base.h (right):

https://codereview.chromium.org/2024953003/diff/1/services/util/cpp/test/test...
services/util/cpp/test/test_base.h:11: namespace {
I'm not sure what the value of the added class is. Moreover, why is there an
anonymous namespace in a header file?

[dalesat, 2016-06-01 00:01:29]

On 2016/05/31 23:37:01, viettrungluu wrote:
>
https://codereview.chromium.org/2024953003/diff/1/services/util/cpp/test/test...
> File services/util/cpp/test/test_base.h (right):
> 
>
https://codereview.chromium.org/2024953003/diff/1/services/util/cpp/test/test...
> services/util/cpp/test/test_base.h:11: namespace {
> I'm not sure what the value of the added class is. Moreover, why is there an
> anonymous namespace in a header file?

Yeah, that looks wrong. I've prepared a CL to fix this and other similar test
code.