services/media/framework/BUILD.gn - Issue 2024953003: Motown: Move framework/util/incident* so other services can use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/framework/BUILD.gn

Issue 2024953003: Motown: Move framework/util/incident* so other services can use it (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/media/factory_service/network_reader_impl.h ('k') | services/media/framework/parts/reader_cache.h » ('j') | services/util/cpp/test/test_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/media/framework/BUILD.gn

diff --git a/services/media/framework/BUILD.gn b/services/media/framework/BUILD.gn

index e99a5a1e89b7939f059e33738277604d0e76644d..6dd573bfbd92e8efef33d6933a2d8fc25e2f6b15 100644

--- a/services/media/framework/BUILD.gn

+++ b/services/media/framework/BUILD.gn

@@ -78,8 +78,6 @@ source_set("framework") {

"util/conversion_pipeline_builder.h",

"util/formatting.cc",

"util/formatting.h",

- "util/incident.cc",

- "util/incident.h",

"util/lpcm_util.cc",

"util/lpcm_util.h",

"util/safe_clone.h",

@@ -89,6 +87,7 @@ source_set("framework") {

"//base",

"//mojo/public/cpp/application",

"//mojo/public/cpp/bindings:callback",

+ "//services/util/cpp",

]

}

@@ -98,7 +97,6 @@ mojo_native_application("apptests") {

testonly = true

sources = [

- "test/incident_test.cc",

"test/sparse_byte_buffer_test.cc",

"test/test_base.h",

]

@@ -109,5 +107,6 @@ mojo_native_application("apptests") {

"//mojo/application",

"//mojo/application:test_support",

"//services/media/framework_create",

+ "//services/util/cpp",

]

}