Issue 202493007: Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 202493007: Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo

Modified:
6 years, 9 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..." Reland this: turns out not responsible. > Revert 257562 "Base: Make base::File use ScopedFD on POSIX." > > Might caused a bunch of layout test failures, at least on Linux > > fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html, > fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html, > fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html, > fast/dom/Window/property-access-on-cached-window-after-frame-removed.html > > > Base: Make base::File use ScopedFD on POSIX. > > > > Now that ScopedFD lives outside of file_util, File can use it to remove manual > > lifetime management. > > > > This also standarizes the behavior on Close failures for all platforms. > > > > BUG=none > > > > Review URL: https://codereview.chromium.org/201083002 > > TBR=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/202583005 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257581

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -29 lines)			Patch
M	trunk/src/base/files/file.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/base/files/file.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	trunk/src/base/files/file_posix.cc	View	13 chunks	+28 lines, -26 lines	0 comments	Download
M	trunk/src/base/files/file_win.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r257581.

Expand Messages | Collapse Messages