Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: trunk/src/base/files/file.h

Issue 202493007: Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/base/files/file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/files/file.h
===================================================================
--- trunk/src/base/files/file.h (revision 257580)
+++ trunk/src/base/files/file.h (working copy)
@@ -12,6 +12,7 @@
#include "base/base_export.h"
#include "base/basictypes.h"
+#include "base/files/scoped_file.h"
#include "base/move.h"
#include "base/time/time.h"
@@ -177,7 +178,7 @@
// return;
Error error_details() const { return error_details_; }
- PlatformFile GetPlatformFile() const { return file_; }
+ PlatformFile GetPlatformFile() const;
PlatformFile TakePlatformFile();
// Destroying this object closes the file automatically.
@@ -276,7 +277,7 @@
#if defined(OS_WIN)
win::ScopedHandle file_;
#elif defined(OS_POSIX)
- PlatformFile file_;
+ ScopedFD file_;
#endif
Error error_details_;
« no previous file with comments | « no previous file | trunk/src/base/files/file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698