Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 202583005: Revert 257562 "Base: Make base::File use ScopedFD on POSIX." (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 257562 "Base: Make base::File use ScopedFD on POSIX." Might caused a bunch of layout test failures, at least on Linux fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html, fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html, fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html, fast/dom/Window/property-access-on-cached-window-after-frame-removed.html > Base: Make base::File use ScopedFD on POSIX. > > Now that ScopedFD lives outside of file_util, File can use it to remove manual > lifetime management. > > This also standarizes the behavior on Close failures for all platforms. > > BUG=none > > Review URL: https://codereview.chromium.org/201083002 TBR=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M trunk/src/base/files/file.h View 3 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/base/files/file.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/base/files/file_posix.cc View 13 chunks +26 lines, -28 lines 0 comments Download
M trunk/src/base/files/file_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Zhenyao Mo
6 years, 9 months ago (2014-03-18 02:07:08 UTC) #1
Zhenyao Mo
Committed patchset #1 manually as r257577.
6 years, 9 months ago (2014-03-18 02:07:18 UTC) #2
rvargas (doing something else)
On 2014/03/18 02:07:18, Zhenyao Mo wrote: > Committed patchset #1 manually as r257577. Do you ...
6 years, 9 months ago (2014-03-18 02:34:48 UTC) #3
Zhenyao Mo
On 2014/03/18 02:34:48, rvargas wrote: > On 2014/03/18 02:07:18, Zhenyao Mo wrote: > > Committed ...
6 years, 9 months ago (2014-03-18 02:36:25 UTC) #4
Zhenyao Mo
On 2014/03/18 02:36:25, Zhenyao Mo wrote: > On 2014/03/18 02:34:48, rvargas wrote: > > On ...
6 years, 9 months ago (2014-03-18 02:37:31 UTC) #5
Zhenyao Mo
6 years, 9 months ago (2014-03-18 02:43:48 UTC) #6
Message was sent while issue was closed.
On 2014/03/18 02:37:31, Zhenyao Mo wrote:
> On 2014/03/18 02:36:25, Zhenyao Mo wrote:
> > On 2014/03/18 02:34:48, rvargas wrote:
> > > On 2014/03/18 02:07:18, Zhenyao Mo wrote:
> > > > Committed patchset #1 manually as r257577.
> > > 
> > > Do you have a link to the failing bot? I'm not seeing the failure.
> > 
> > Here you go:
> >
http://build.chromium.org/p/chromium.webkit/builders/WebKit%252520Linux%25252032
> > 
> > Might not be you.  There are two chromium CLs in the range.  Either this one
> or
> > the other one.
> > 
> > I should be able to tell soon.
> 
> OK, not this one.  I am relanding it.

Relanded in r257581

Powered by Google App Engine
This is Rietveld 408576698