Disable warning 4702: Unreachable code for the WPO/PGO builds.

Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934
Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}

Committed: https://crrev.com/70bc55033e16ed4696ccbaf7e091d426d538bd08
Cr-Commit-Position: refs/heads/master@{#396659}

[Sébastien Marchand, 2016-05-28 14:12:13]

Patchset #2 (id:20001) has been deleted

[Sébastien Marchand, 2016-05-28 14:12:51]

sebmarchand@chromium.org changed reviewers:
+ scottmg@chromium.org

[Sébastien Marchand, 2016-05-28 14:12:51]

PTAL.

[scottmg, 2016-05-28 18:46:44]

lgtm

https://codereview.chromium.org/2023653002/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2023653002/diff/40001/build/common.gypi#newco...
build/common.gypi:5531: 4702
Why isn't this affecting pdfium on the PGO bot?

[Sébastien Marchand, 2016-05-28 18:53:50]

https://codereview.chromium.org/2023653002/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/2023653002/diff/40001/build/common.gypi#newco...
build/common.gypi:5531: 4702
On 2016/05/28 18:46:43, scottmg wrote:
> Why isn't this affecting pdfium on the PGO bot?

We're not using optimize=max on the PGO bot, we keep the default optimize value
for each target.

[Sébastien Marchand, 2016-05-28 18:53:56]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-05-28 18:54:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023653002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023653002/40001

[commit-bot: I haz the power, 2016-05-28 18:57:18]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-28 18:58:54]

Description was changed from

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934
==========

to

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

[commit-bot: I haz the power, 2016-05-28 18:58:55]

Patchset 2 (id:??) landed as
https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}

[Lei Zhang, 2016-05-29 00:38:29]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2023693003/ by thestig@chromium.org.

The reason for reverting is: Broke DrMemory builders:

gyp: Key 'conditions' repeated at level 5 with key path
'conditions.12.1.target_defaults' while reading
C:\b\build\slave\drm-cr\build\src\build\common.gypi while reading
includes of C:\b\build\slave\drm-cr\build\src\build\all.gyp
.

[Sébastien Marchand, 2016-05-29 13:47:43]

Description was changed from

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

to

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

[Sébastien Marchand, 2016-05-29 13:54:30]

Hum, I've moved the 'full_wpo_on_official==1' with the other conditions for this
target, that should fix this ? (I can't repro it locally)

[scottmg, 2016-05-29 16:05:15]

On 2016/05/29 13:54:30, Sébastien Marchand wrote:
> Hum, I've moved the 'full_wpo_on_official==1' with the other conditions for
this
> target, that should fix this ? (I can't repro it locally)

https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium...

lgtm though

[Sébastien Marchand, 2016-05-29 16:19:21]

We should probably enable these GYP checks on some of the try bots (but it might
also be irrelevant as we're moving to GN).

Confirmed that ps #3 fix the issue.

[Sébastien Marchand, 2016-05-29 16:19:27]

The CQ bit was checked by sebmarchand@chromium.org

[commit-bot: I haz the power, 2016-05-29 16:19:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2023653002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2023653002/60001

[commit-bot: I haz the power, 2016-05-29 16:48:08]

Description was changed from

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

to

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

[commit-bot: I haz the power, 2016-05-29 16:48:09]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-29 16:50:07]

Description was changed from

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}
==========

to

==========
Disable warning 4702: Unreachable code for the WPO/PGO builds.

BUG=490934

Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936
Cr-Commit-Position: refs/heads/master@{#396647}

Committed: https://crrev.com/70bc55033e16ed4696ccbaf7e091d426d538bd08
Cr-Commit-Position: refs/heads/master@{#396659}
==========

[commit-bot: I haz the power, 2016-05-29 16:50:08]

Patchset 3 (id:??) landed as
https://crrev.com/70bc55033e16ed4696ccbaf7e091d426d538bd08
Cr-Commit-Position: refs/heads/master@{#396659}