Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: build/common.gypi

Issue 2023653002: Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handle_verifier
Patch Set: Move the condition to the other conditions group. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5528 matching lines...) Expand 10 before | Expand all | Expand 10 after
5539 ], 5539 ],
5540 }], 5540 }],
5541 ['msvs_xtree_patched!=1', { 5541 ['msvs_xtree_patched!=1', {
5542 # If xtree hasn't been patched, then we disable C4702. Otherwise, 5542 # If xtree hasn't been patched, then we disable C4702. Otherwise,
5543 # it's enabled. This will generally only be true for system-level 5543 # it's enabled. This will generally only be true for system-level
5544 # installed Express users. 5544 # installed Express users.
5545 'msvs_disabled_warnings': [ 5545 'msvs_disabled_warnings': [
5546 4702, # unreachable code 5546 4702, # unreachable code
5547 ], 5547 ],
5548 }], 5548 }],
5549 ['full_wpo_on_official==1', {
5550 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
5551 # builds. Probably anything that this would catch that
5552 # wouldn't be caught in a normal build isn't going to
5553 # actually be a bug, so the incremental value of C4702 for
5554 # PGO builds is likely very small.
5555 'msvs_disabled_warnings': [
5556 4702
5557 ],
5558 }],
5549 ], 5559 ],
5550 # Add extra include directories here that need to be in front of the 5560 # Add extra include directories here that need to be in front of the
5551 # installed and packaged include directories. This may be needed in 5561 # installed and packaged include directories. This may be needed in
5552 # order to force a particular SDK version, such as to get VS 2013 to use 5562 # order to force a particular SDK version, such as to get VS 2013 to use
5553 # the Windows 10 SDK. Beware of making the INCLUDE variable excessively 5563 # the Windows 10 SDK. Beware of making the INCLUDE variable excessively
5554 # long, and be sure to make corresponding changes to 5564 # long, and be sure to make corresponding changes to
5555 # build\toolchain\win\setup_toolchain.py 5565 # build\toolchain\win\setup_toolchain.py
5556 'msvs_system_include_dirs': [ 5566 'msvs_system_include_dirs': [
5557 ], 5567 ],
5558 'msvs_cygwin_shell': 0, 5568 'msvs_cygwin_shell': 0,
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
6286 # settings in target dicts. SYMROOT is a special case, because many other 6296 # settings in target dicts. SYMROOT is a special case, because many other
6287 # Xcode variables depend on it, including variables such as 6297 # Xcode variables depend on it, including variables such as
6288 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6298 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6289 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6299 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6290 # files to appear (when present) in the UI as actual files and not red 6300 # files to appear (when present) in the UI as actual files and not red
6291 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6301 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6292 # and therefore SYMROOT, needs to be set at the project level. 6302 # and therefore SYMROOT, needs to be set at the project level.
6293 'SYMROOT': '<(DEPTH)/xcodebuild', 6303 'SYMROOT': '<(DEPTH)/xcodebuild',
6294 }, 6304 },
6295 } 6305 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698