Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: build/common.gypi

Issue 2023653002: Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handle_verifier
Patch Set: Move the condition to the other conditions group. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 91fcfd87daa034e37e82c096a102dcddbccd733b..4b008a4d8431024b0feee30ccb5b56af13ba192e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5546,6 +5546,16 @@
4702, # unreachable code
],
}],
+ ['full_wpo_on_official==1', {
+ # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
+ # builds. Probably anything that this would catch that
+ # wouldn't be caught in a normal build isn't going to
+ # actually be a bug, so the incremental value of C4702 for
+ # PGO builds is likely very small.
+ 'msvs_disabled_warnings': [
+ 4702
+ ],
+ }],
],
# Add extra include directories here that need to be in front of the
# installed and packaged include directories. This may be needed in
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698