[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

Committed: https://crrev.com/f60c2289f4ac727397e04c1b774af9711897eef1
Cr-Commit-Position: refs/heads/master@{#398376}

[chongz, 2016-06-01 15:14:48]

Patchset #1 (id:1) has been deleted

[chongz, 2016-06-01 15:14:57]

Patchset #1 (id:20001) has been deleted

[chongz, 2016-06-01 15:15:21]

Patchset #1 (id:40001) has been deleted

[chongz, 2016-06-01 15:25:43]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

BUG=609142
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it does not mutate on DOM
change, so using |StaticRange| won't slow down DOM operations.

|StaticRange| should be used in new types of Events, and it provides method
|toRange()| to up-convert to a fully featured |Range| object when necessary.

It's |RuntimeEnabled=InputEvent| since it's currently only used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
BUG=609142
==========

[chongz, 2016-06-01 15:27:12]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it does not mutate on DOM
change, so using |StaticRange| won't slow down DOM operations.

|StaticRange| should be used in new types of Events, and it provides method
|toRange()| to up-convert to a fully featured |Range| object when necessary.

It's |RuntimeEnabled=InputEvent| since it's currently only used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
BUG=609142
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new types of Events, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
BUG=609142
==========

[chongz, 2016-06-01 15:27:57]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new types of Events, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
BUG=609142
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new types of Events, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
==========

[chongz, 2016-06-01 15:28:29]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new types of Events, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
==========

[chongz, 2016-06-01 16:00:47]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2016-06-01 16:00:48]

dtapuska@ PTAL, thanks!

[dtapuska, 2016-06-02 15:26:30]

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StaticRange.cpp (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.cpp:46: return
toRangeImpl(*scriptState->domWindow()->document(), exceptionState);
Is this correct? does this work across iframes?

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StaticRange.h (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.h:57: explicit StaticRange();
why explicit on non param constructor? doesn't make sense.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.h:62: Member<Node>
m_startContainer;
I guess my hope was that in the class structure

Range would extend a StaticRange.

Is that not possible?

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: for (const auto& range
: m_ranges) {
brackets not needed.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:99: return staticRanges;
Does this create a new object; or should std::move be used here... Hopefully the
compiler is being smart.

[chongz, 2016-06-06 19:43:44]

dtapuska@ PTAL, thanks!

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StaticRange.cpp (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.cpp:46: return
toRangeImpl(*scriptState->domWindow()->document(), exceptionState);
On 2016/06/02 15:26:29, dtapuska wrote:
> Is this correct? does this work across iframes?

Fixed by passing |Document| to constructor.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/StaticRange.h (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.h:57: explicit StaticRange();
On 2016/06/02 15:26:29, dtapuska wrote:
> why explicit on non param constructor? doesn't make sense.

Added |Document&|.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/StaticRange.h:62: Member<Node>
m_startContainer;
On 2016/06/02 15:26:29, dtapuska wrote:
> I guess my hope was that in the class structure
> 
> Range would extend a StaticRange.
> 
> Is that not possible?

garykac@ mentioned that there are concerns about changing |Range|, see
https://github.com/garykac/staticrange/issues/1#issuecomment-223659174

For now can we keep them separate and maybe merge later when decided?
Also currently |StaticRange| is |RuntimeEnabled=InputEvent|.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: for (const auto& range
: m_ranges) {
On 2016/06/02 15:26:29, dtapuska wrote:
> brackets not needed.

Done.

https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:99: return staticRanges;
On 2016/06/02 15:26:29, dtapuska wrote:
> Does this create a new object; or should std::move be used here... Hopefully
the
> compiler is being smart.

According to go/totw/11 I'd assume compiler is smart enough to optimize it?

[dtapuska, 2016-06-06 20:12:38]

On 2016/06/06 19:43:44, chongz wrote:
> dtapuska@ PTAL, thanks!
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/StaticRange.cpp (right):
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/StaticRange.cpp:46: return
> toRangeImpl(*scriptState->domWindow()->document(), exceptionState);
> On 2016/06/02 15:26:29, dtapuska wrote:
> > Is this correct? does this work across iframes?
> 
> Fixed by passing |Document| to constructor.
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/StaticRange.h (right):
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/StaticRange.h:57: explicit StaticRange();
> On 2016/06/02 15:26:29, dtapuska wrote:
> > why explicit on non param constructor? doesn't make sense.
> 
> Added |Document&|.
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/StaticRange.h:62: Member<Node>
> m_startContainer;
> On 2016/06/02 15:26:29, dtapuska wrote:
> > I guess my hope was that in the class structure
> > 
> > Range would extend a StaticRange.
> > 
> > Is that not possible?
> 
> garykac@ mentioned that there are concerns about changing |Range|, see
> https://github.com/garykac/staticrange/issues/1#issuecomment-223659174
> 
> For now can we keep them separate and maybe merge later when decided?
> Also currently |StaticRange| is |RuntimeEnabled=InputEvent|.
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/InputEvent.cpp (right):
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/InputEvent.cpp:96: for (const auto&
range
> : m_ranges) {
> On 2016/06/02 15:26:29, dtapuska wrote:
> > brackets not needed.
> 
> Done.
> 
>
https://codereview.chromium.org/2022863002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/InputEvent.cpp:99: return staticRanges;
> On 2016/06/02 15:26:29, dtapuska wrote:
> > Does this create a new object; or should std::move be used here... Hopefully
> the
> > compiler is being smart.
> 
> According to go/totw/11 I'd assume compiler is smart enough to optimize it?

lgtm

[chongz, 2016-06-06 20:17:32]

chongz@chromium.org changed reviewers:
+ ojan@chromium.org

[chongz, 2016-06-06 20:17:32]

ojan@ PTAL at the second |StaticRange| CL, thanks!

[ojan, 2016-06-06 21:06:11]

The CQ bit was checked by ojan@chromium.org

[ojan, 2016-06-06 21:06:11]

lgtm

[commit-bot: I haz the power, 2016-06-06 21:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022863002/80001

[commit-bot: I haz the power, 2016-06-07 02:04:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:04:09]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chongz, 2016-06-07 19:27:25]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-06-07 19:27:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, ojan@chromium.org
Link to the patchset: https://codereview.chromium.org/2022863002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-07 19:31:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022863002/100001

[dglazkov, 2016-06-07 19:39:10]

Do we have an Intent to Implement?

[chongz, 2016-06-07 20:08:03]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/beforeinp...
==========

[chongz, 2016-06-07 20:09:34]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/beforeinp...
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...
==========

[chongz, 2016-06-07 20:11:05]

On 2016/06/07 19:39:10, dglazkov wrote:
> Do we have an Intent to Implement?

Yes, the original Intent to Implement and Ship was changed to Intent to
Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...

[dglazkov, 2016-06-07 20:13:39]

On 2016/06/07 at 20:11:05, chongz wrote:
> On 2016/06/07 19:39:10, dglazkov wrote:
> > Do we have an Intent to Implement?
> 
> Yes, the original Intent to Implement and Ship was changed to Intent to
Implement:
>
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...

Got it. Searched for StaticRange and didn't find it on blink-dev.

[commit-bot: I haz the power, 2016-06-07 21:30:43]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...
==========

[commit-bot: I haz the power, 2016-06-07 21:30:44]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-07 21:33:16]

Description was changed from

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...
==========

to

==========
[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

|StaticRange| is a lightweight version of |Range|, but it
does not mutate on DOM change, so using |StaticRange| won't
slow down DOM operations.

|StaticRange| should be used in new APIs, and it
provides method |toRange()| to up-convert to a fully
featured |Range| object when necessary.

Currently it's |RuntimeEnabled=InputEvent| since it's only
used by |InputEvent|.

Proposal=https://github.com/garykac/staticrange/blob/master/staticrange.md
WICG=https://discourse.wicg.io/t/proposal-staticrange-to-be-used-instead-of-range-for-new-apis/1472
BUG=609142

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEven...

Committed: https://crrev.com/f60c2289f4ac727397e04c1b774af9711897eef1
Cr-Commit-Position: refs/heads/master@{#398376}
==========

[commit-bot: I haz the power, 2016-06-07 21:33:17]

Patchset 3 (id:??) landed as
https://crrev.com/f60c2289f4ac727397e04c1b774af9711897eef1
Cr-Commit-Position: refs/heads/master@{#398376}