[InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()|

third_party/WebKit/Source/core/events/InputEvent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/events/InputEvent.h"
 
 #include "core/dom/Range.h"
 #include "core/events/EventDispatcher.h"
 #include "public/platform/WebEditingCommandType.h"
 
@@ skipping 72 matching lines @@
         inputEventInit.setRanges(*ranges);
 
     return InputEvent::create(EventTypeNames::beforeinput, inputEventInit);
 }
 
 String InputEvent::inputType() const
 {
     return convertInputTypeToString(m_inputType);
 }
 
+StaticRangeVector InputEvent::getRanges() const
+{
+    StaticRangeVector staticRanges;
+    for (const auto& range : m_ranges) {

[dtapuska, 2016/06/02 15:26:29]

brackets not needed.

[chongz, 2016/06/06 19:43:44]

Done.

+        staticRanges.append(StaticRange::create(range->startContainer(), range->startOffset(), range->endContainer(), range->endOffset()));
+    }
+    return staticRanges;

[dtapuska, 2016/06/02 15:26:29]

Does this create a new object; or should std::move be used here... Hopefully the
compiler is being smart.

[chongz, 2016/06/06 19:43:43]

According to go/totw/11 I'd assume compiler is smart enough to optimize it?

+}
+
 bool InputEvent::isInputEvent() const
 {
     return true;
 }
 
 // TODO(chongz): We should get rid of this |EventDispatchMediator| pattern and introduce
 // simpler interface such as |beforeDispatchEvent()| and |afterDispatchEvent()| virtual methods.
 EventDispatchMediator* InputEvent::createMediator()
 {
     return InputEventDispatchMediator::create(this);
@@ skipping 32 matching lines @@
     //   3. We don't want authors to hold live |Range| indefinitely by holding |InputEvent|, so we
     //      clear them after dispatch.
     // Authors should explicitly call |getRanges()|->|toRange()| if they want to keep a copy of |Range|.
     // See Editing TF meeting notes:
     // https://docs.google.com/document/d/1hCj6QX77NYIVY0RWrMHT1Yra6t8_Qu8PopaWLG0AM58/edit?usp=sharing
     event().m_ranges.clear();
     return result;
 }
 
 } // namespace blink