Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.h

Issue 2022863002: [InputEvent] Introduce |StaticRange| and use in |InputEvent::getRanges()| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/InputEvent.h
diff --git a/third_party/WebKit/Source/core/events/InputEvent.h b/third_party/WebKit/Source/core/events/InputEvent.h
index b16f476de889a3b9c5e99100004ff2ea44978437..35ee6dc19e47dbd96d4388160132d6b94ca42a45 100644
--- a/third_party/WebKit/Source/core/events/InputEvent.h
+++ b/third_party/WebKit/Source/core/events/InputEvent.h
@@ -5,13 +5,12 @@
#ifndef InputEvent_h
#define InputEvent_h
+#include "core/dom/StaticRange.h"
#include "core/events/InputEventInit.h"
#include "core/events/UIEvent.h"
namespace blink {
-class Range;
-
class InputEvent final : public UIEvent {
DEFINE_WRAPPERTYPEINFO();
@@ -56,8 +55,7 @@ public:
bool isComposing() const { return m_isComposing; }
// Returns a copy of target ranges during event dispatch, and returns an empty
// vector after dispatch.
- // TODO(chongz): Return Vector<StaticRange>.
- HeapVector<Member<Range>> getRanges() const { return m_ranges; };
+ StaticRangeVector getRanges() const;
bool isInputEvent() const override;
« no previous file with comments | « third_party/WebKit/Source/core/dom/StaticRangeTest.cpp ('k') | third_party/WebKit/Source/core/events/InputEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698