Always disable session invalidations when not on the recent tabs page

Always disable session invalidations when not on the recent tabs page

This CL removes checking for the AndroidSessionNotifications field trial

Committed: https://crrev.com/4e3e0235a95cb7eebe3a67ee65a8ece551ad1b46
Cr-Commit-Position: refs/heads/master@{#398651}

[pkotwicz, 2016-05-31 21:17:45]

pkotwicz@chromium.org changed reviewers:
+ nyquist@chromium.org, skym@chromium.org

[pkotwicz, 2016-05-31 21:17:46]

Tommy can you please take a look? Based on your e-mail, I am unsure whether you
want to remove the histogram or not.

skym@ It looks like the PageRevisitInstrumentation experiment has expired on
Stable and Beta and will soon expire on Chrome Dev. Are you planning on
extending the Chrome Dev experiment?

[maxbogue, 2016-05-31 23:53:32]

maxbogue@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-05-31 23:53:32]

FYI, Sky is out on paternity leave. +cc Nicolas to comment on the revisit stuff.

[Nicolas Zea, 2016-06-02 00:01:04]

zea@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2016-06-02 00:01:05]

We're currently re-running the page revisit experiment on stable right now
actually. Can we hold off on this for a bit?

[pkotwicz, 2016-06-03 15:39:26]

Tommy: can you please take a look at the CL as is?

Nicolas: are there any issues with the CLs as is. The CL currently does not
affect the PageRevisitInstrumentation experiment at all

[nyquist, 2016-06-03 16:50:14]

zea: So, I'm unsure here. Is an interesting stat related to page revisit the
Sync.InvalidationSessionsAndroid that is planned to be removed here?

[Nicolas Zea, 2016-06-03 18:55:50]

On 2016/06/03 16:50:14, nyquist wrote:
> zea: So, I'm unsure here. Is an interesting stat related to page revisit the
> Sync.InvalidationSessionsAndroid that is planned to be removed here?

Having the notifications, and hence up to date sessions data without visiting
the recent tabs page, affects our ability to measure whether a page the user
visited on their android device is one they recently visited on another device.
Without notifications we can't rely on that data.

[pkotwicz, 2016-06-03 19:09:27]

zea@: I am confused. This CL does not affect whether session notifications are
sent or not. I am confused whether the Sync.InvalidationSessionsAndroid
histogram is useful to your team

[Nicolas Zea, 2016-06-03 19:38:54]

On 2016/06/03 19:09:27, pkotwicz wrote:
> zea@: I am confused. This CL does not affect whether session notifications are
> sent or not. I am confused whether the Sync.InvalidationSessionsAndroid
> histogram is useful to your team

The histogram itself isn't useful to us. What is useful to us is registering for
and receiving session invalidation even when not on the recent tabs page.

[pkotwicz, 2016-06-03 20:36:52]

zea: This CL does not change when session invalidations are sent / received

[Nicolas Zea, 2016-06-03 20:38:48]

On 2016/06/03 20:36:52, pkotwicz wrote:
> zea: This CL does not change when session invalidations are sent / received

Isn't that what the change in InvalidationController.java is doing (and what the
commit description says)?

Although now that I look closely, it looks like it only turns it off if the
revisit experiment isn't enabled. I hadn't noticed that before, and that part
addresses my concerns. Given that LGTM.

[pkotwicz, 2016-06-07 19:51:28]

Tommy: ping!

[nyquist, 2016-06-07 21:55:24]

lgtm

[pkotwicz, 2016-06-07 21:59:50]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-06-07 22:00:11]

The CQ bit was unchecked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-06-07 22:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022303002/1

[pkotwicz, 2016-06-07 22:00:38]

pkotwicz@chromium.org changed reviewers:
+ isherman@chromium.org

[pkotwicz, 2016-06-07 22:00:39]

isherman@ for tools/metrics

[Ilya Sherman, 2016-06-07 22:32:41]

histograms.xml lgtm

[pkotwicz, 2016-06-08 18:56:36]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-06-08 18:57:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2022303002/1

[commit-bot: I haz the power, 2016-06-08 20:11:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 20:13:40]

Description was changed from

==========
Always disable session invalidations when not on the recent tabs page

This CL removes checking for the AndroidSessionNotifications field trial
==========

to

==========
Always disable session invalidations when not on the recent tabs page

This CL removes checking for the AndroidSessionNotifications field trial

Committed: https://crrev.com/4e3e0235a95cb7eebe3a67ee65a8ece551ad1b46
Cr-Commit-Position: refs/heads/master@{#398651}
==========

[commit-bot: I haz the power, 2016-06-08 20:13:42]

Patchset 1 (id:??) landed as
https://crrev.com/4e3e0235a95cb7eebe3a67ee65a8ece551ad1b46
Cr-Commit-Position: refs/heads/master@{#398651}